# [PATCH] branch.c: change install_branch_config() to use skip_prefix() 3 messages from 2014-03-02 to 2014-03-02. Participants: Guanglin Xu, Jacopo Notarstefano. Thread: https://gitlist.dev/t/36021 ## Guanglin Xu, 2014-03-02 11:52 Subject: [PATCH] branch.c: change install_branch_config() to use skip_prefix() Message-ID: <1393761147-13590-1-git-send-email-mzguanglin@gmail.com> URL: https://gitlist.dev/e/1393761147-13590-1-git-send-email-mzguanglin%40gmail.com ``` GSoC2014 Microproject: according to the idea#2 for microprojects, change install_branch_config() to use skip_prefix() and make it conform to the usage of previous starts_with(). Signed-off-by: Guanglin Xu --- branch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/branch.c b/branch.c index 723a36b..ca4e824 100644 --- a/branch.c +++ b/branch.c @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin) void install_branch_config(int flag, const char *local, const char *origin, const char *remote) { const char *shortname = remote + 11; - int remote_is_branch = starts_with(remote, "refs/heads/"); + int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/")); struct strbuf key = STRBUF_INIT; int rebasing = should_setup_rebase(origin); -- 1.9.0 Hi, I am Guanglin Xu. I plan to apply for GSoC 2014. ``` ## Jacopo Notarstefano, 2014-03-02 14:01 Subject: Re: [PATCH] branch.c: change install_branch_config() to use skip_prefix() Message-ID: URL: https://gitlist.dev/e/CAL0uuq0Vc7uZdixLV6OciAZWFYcif_WMCNABEvC%3D6gT5s%2BmthQ%40mail.gmail.com In-Reply-To: <1393761147-13590-1-git-send-email-mzguanglin@gmail.com> ``` The part about this being a GSoC microproject should go below the three dashes, since it's not information that needs to be recorded in the codebase. On Sun, Mar 2, 2014 at 12:52 PM, Guanglin Xu wrote: > GSoC2014 Microproject: according to the idea#2 for microprojects, change install_branch_config() to use skip_prefix() and make it conform to the usage of previous starts_with(). > > Signed-off-by: Guanglin Xu > --- > branch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/branch.c b/branch.c > index 723a36b..ca4e824 100644 > --- a/branch.c > +++ b/branch.c > @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin) > void install_branch_config(int flag, const char *local, const char *origin, const char *remote) > { > const char *shortname = remote + 11; > - int remote_is_branch = starts_with(remote, "refs/heads/"); > + int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/")); > struct strbuf key = STRBUF_INIT; > int rebasing = should_setup_rebase(origin); > > -- > 1.9.0 > > Hi, > I am Guanglin Xu. I plan to apply for GSoC 2014. > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Guanglin Xu, 2014-03-02 16:01 Subject: Re: [PATCH] branch.c: change install_branch_config() to use skip_prefix() Message-ID: URL: https://gitlist.dev/e/CAATe9uiCz_fe65%3DO_qVUX5OWbbFj4nqBZDsB_0dMt175HLCFDg%40mail.gmail.com In-Reply-To: ``` Hi Jacopo, Thanks for your comments. I just update this PATCH as v2. I appreciate more comments from you and others in the new thread. Regards, Guanglin 2014-03-02 22:01 GMT+08:00 Jacopo Notarstefano : > The part about this being a GSoC microproject should go below the > three dashes, since it's not information that needs to > be recorded in the codebase. > > On Sun, Mar 2, 2014 at 12:52 PM, Guanglin Xu wrote: >> GSoC2014 Microproject: according to the idea#2 for microprojects, change install_branch_config() to use skip_prefix() and make it conform to the usage of previous starts_with(). >> >> Signed-off-by: Guanglin Xu >> --- >> branch.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/branch.c b/branch.c >> index 723a36b..ca4e824 100644 >> --- a/branch.c >> +++ b/branch.c >> @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin) >> void install_branch_config(int flag, const char *local, const char *origin, const char *remote) >> { >> const char *shortname = remote + 11; >> - int remote_is_branch = starts_with(remote, "refs/heads/"); >> + int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/")); >> struct strbuf key = STRBUF_INIT; >> int rebasing = should_setup_rebase(origin); >> >> -- >> 1.9.0 >> >> Hi, >> I am Guanglin Xu. I plan to apply for GSoC 2014. >> -- >> To unsubscribe from this list: send the line "unsubscribe git" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ```