# [PATCH v3] write_pack_file: use correct variable in diagnostic

4 messages from 2014-03-02 to 2014-03-03. Participants: Sun He, Eric Sunshine, He Sun, Junio C Hamano.
Thread: https://gitlist.dev/t/36018

## Sun He, 2014-03-02 07:30

Subject: [PATCH v3] write_pack_file: use correct variable in diagnostic
Message-ID: <1393745411-30980-1-git-send-email-sunheehnus@gmail.com>
URL: https://gitlist.dev/e/1393745411-30980-1-git-send-email-sunheehnus%40gmail.com

```
'pack_tmp_name' is the subject of the utime() check, so report it in the
warning, not the uninitialized 'tmpname'

Signed-off-by: Sun He <sunheehnus@gmail.com>
---

 Changing the subject and adding valid information as tutored by 
 Eric Sunshine.
 Thanks to him.

 builtin/pack-objects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
 				utb.modtime = --last_mtime;
 				if (utime(pack_tmp_name, &utb) < 0)
 					warning("failed utime() on %s: %s",
-						tmpname, strerror(errno));
+						pack_tmp_name, strerror(errno));
 			}
 
 			/* Enough space for "-<sha-1>.pack"? */
-- 
1.9.0.138.g2de3478.dirty

```

## Eric Sunshine, 2014-03-02 18:42

Subject: Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
Message-ID: <CAPig+cSuBfuzL-NXYkvFoz5+jPrEUNfTqoMf-iAYyMSv3jDsqg@mail.gmail.com>
URL: https://gitlist.dev/e/CAPig%2BcSuBfuzL-NXYkvFoz5%2BjPrEUNfTqoMf-iAYyMSv3jDsqg%40mail.gmail.com
In-Reply-To: <1393745411-30980-1-git-send-email-sunheehnus@gmail.com>

```
On Sun, Mar 2, 2014 at 2:30 AM, Sun He <sunheehnus@gmail.com> wrote:
> 'pack_tmp_name' is the subject of the utime() check, so report it in the
> warning, not the uninitialized 'tmpname'
>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
>  Changing the subject and adding valid information as tutored by
>  Eric Sunshine.
>  Thanks to him.
>
>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>                                 utb.modtime = --last_mtime;
>                                 if (utime(pack_tmp_name, &utb) < 0)
>                                         warning("failed utime() on %s: %s",
> -                                               tmpname, strerror(errno));
> +                                               pack_tmp_name, strerror(errno));
>                         }
>
>                         /* Enough space for "-<sha-1>.pack"? */
> --
> 1.9.0.138.g2de3478.dirty

Nicely done. Everything is where it ought to be.

As this is an actual bug fix (not just a GSoC microproject):

Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

```

## He Sun, 2014-03-03 01:20

Subject: Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
Message-ID: <CAJr59C1Azr9EnoeRPKZF+AB9GBw1RR7fUkvaYChyTfHwoJSvFA@mail.gmail.com>
URL: https://gitlist.dev/e/CAJr59C1Azr9EnoeRPKZF%2BAB9GBw1RR7fUkvaYChyTfHwoJSvFA%40mail.gmail.com
In-Reply-To: <CAPig+cSuBfuzL-NXYkvFoz5+jPrEUNfTqoMf-iAYyMSv3jDsqg@mail.gmail.com>

```
2014-03-03 2:42 GMT+08:00 Eric Sunshine <sunshine@sunshineco.com>:
> On Sun, Mar 2, 2014 at 2:30 AM, Sun He <sunheehnus@gmail.com> wrote:
>> 'pack_tmp_name' is the subject of the utime() check, so report it in the
>> warning, not the uninitialized 'tmpname'
>>
>> Signed-off-by: Sun He <sunheehnus@gmail.com>
>> ---
>>
>>  Changing the subject and adding valid information as tutored by
>>  Eric Sunshine.
>>  Thanks to him.
>>
>>  builtin/pack-objects.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
>> index c733379..4922ce5 100644
>> --- a/builtin/pack-objects.c
>> +++ b/builtin/pack-objects.c
>> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>>                                 utb.modtime = --last_mtime;
>>                                 if (utime(pack_tmp_name, &utb) < 0)
>>                                         warning("failed utime() on %s: %s",
>> -                                               tmpname, strerror(errno));
>> +                                               pack_tmp_name, strerror(errno));
>>                         }
>>
>>                         /* Enough space for "-<sha-1>.pack"? */
>> --
>> 1.9.0.138.g2de3478.dirty
>
> Nicely done. Everything is where it ought to be.
>
> As this is an actual bug fix (not just a GSoC microproject):
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

Thank you so much for everything you have done.
I am honored to do this with all your support and kindness.

Regards，
He Sun

```

## Junio C Hamano, 2014-03-03 18:43

Subject: Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
Message-ID: <xmqqfvmzqg1u.fsf@gitster.dls.corp.google.com>
URL: https://gitlist.dev/e/xmqqfvmzqg1u.fsf%40gitster.dls.corp.google.com
In-Reply-To: <1393745411-30980-1-git-send-email-sunheehnus@gmail.com>

```
Sun He <sunheehnus@gmail.com> writes:

> 'pack_tmp_name' is the subject of the utime() check, so report it in the
> warning, not the uninitialized 'tmpname'
>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
>  Changing the subject and adding valid information as tutored by 
>  Eric Sunshine.
>  Thanks to him.
>
>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>  				utb.modtime = --last_mtime;
>  				if (utime(pack_tmp_name, &utb) < 0)
>  					warning("failed utime() on %s: %s",
> -						tmpname, strerror(errno));
> +						pack_tmp_name, strerror(errno));
>  			}
>  
>  			/* Enough space for "-<sha-1>.pack"? */

Very nicely done.  Thanks.

And big Thanks to Eric guiding this patch through.

```