threads / patch / 36017

v2Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.

Subject: [PATCH v2] Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.

## tl;dr

3 messages between Mar 2, 2014 and Mar 2, 2014. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Sun He· Mar 2, 2014, 02:43 UTC · lore

Signed-off-by: Sun He <sunheehnus@gmail.com>
---

 As tmpname is used without initialization, it should be a mistake.

 builtin/pack-objects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/pack-objects.c +1 −1

diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
 				utb.modtime = --last_mtime;
 				if (utime(pack_tmp_name, &utb) < 0)
 					warning("failed utime() on %s: %s",
-						tmpname, strerror(errno));
+						pack_tmp_name, strerror(errno));
 			}
 
 			/* Enough space for "-<sha-1>.pack"? */

-- 
1.9.0.138.g2de3478.dirty

Eric Sunshine· Mar 2, 2014, 03:59 UTC · re: Sun He · lore

Re: [PATCH v2] Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.

On Sat, Mar 1, 2014 at 9:43 PM, Sun He <sunheehnus@gmail.com> wrote:

> Subject: Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.

The subject should be a short summary of the change, and the rest of the commit message before the "---" line provides extra detail explaining the change.

> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
>  As tmpname is used without initialization, it should be a mistake.

This is valid information for the commit message above the "---" line. So, your full commit message might say something like this:

    Subject: write_pack_file: use correct variable in diagnostic

    'pack_tmp_name' is the subject of the utime() check, so report
    it in the warning, not the uninitialized 'tmpname'.

Show 18 quoted lines

>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>                                 utb.modtime = --last_mtime;
>                                 if (utime(pack_tmp_name, &utb) < 0)
>                                         warning("failed utime() on %s: %s",
> -                                               tmpname, strerror(errno));
> +                                               pack_tmp_name, strerror(errno));
>                         }
>
>                         /* Enough space for "-<sha-1>.pack"? */
> --
> 1.9.0.138.g2de3478.dirty

He Sun· Mar 2, 2014, 07:18 UTC · re: Eric Sunshine · lore

Re: [PATCH v2] Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.

2014-03-02 11:59 GMT+08:00 Eric Sunshine <sunshine@sunshineco.com>:

Show 7 quoted lines

> On Sat, Mar 1, 2014 at 9:43 PM, Sun He <sunheehnus@gmail.com> wrote:
>> Subject: Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.
>
> The subject should be a short summary of the change, and the rest of
> the commit message before the "---" line provides extra detail
> explaining the change.
>

OK, got it. Thank you very much.

Show 13 quoted lines

>> Signed-off-by: Sun He <sunheehnus@gmail.com>
>> ---
>>
>>  As tmpname is used without initialization, it should be a mistake.
>
> This is valid information for the commit message above the "---" line.
> So, your full commit message might say something like this:
>
>     Subject: write_pack_file: use correct variable in diagnostic
>
>     'pack_tmp_name' is the subject of the utime() check, so report
>     it in the warning, not the uninitialized 'tmpname'.
>

Thank you for your suggestion, I will modify it right now. :-)

Show 18 quoted lines

>>  builtin/pack-objects.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
>> index c733379..4922ce5 100644
>> --- a/builtin/pack-objects.c
>> +++ b/builtin/pack-objects.c
>> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>>                                 utb.modtime = --last_mtime;
>>                                 if (utime(pack_tmp_name, &utb) < 0)
>>                                         warning("failed utime() on %s: %s",
>> -                                               tmpname, strerror(errno));
>> +                                               pack_tmp_name, strerror(errno));
>>                         }
>>
>>                         /* Enough space for "-<sha-1>.pack"? */
>> --
>> 1.9.0.138.g2de3478.dirty