threads / patch / 35970

patchbranch: change install_branch_config() to use skip_prefix()

Subject: [PATCH] branch: change install_branch_config() to use skip_prefix()

## tl;dr

4 messages between Feb 27, 2014 and Feb 27, 2014. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Dmitry S. Dolzhenko· Feb 27, 2014, 11:13 UTC · lore

Change install_branch_config() function to use skip_prefix() for getting short name of remote branch.

Signed-off-by: Dmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
---
 branch.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Show changes to branch.c +4 −2

diff --git a/branch.c b/branch.c
index 723a36b..310749b 100644
--- a/branch.c
+++ b/branch.c
@@ -4,6 +4,8 @@
 #include "remote.h"
 #include "commit.h"
 
+static const char refs_heads_prefix[] = "refs/heads/";
+
 struct tracking {
 	struct refspec spec;
 	char *src;
@@ -49,8 +51,8 @@ static int should_setup_rebase(const char *origin)
 
 void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
 {
-	const char *shortname = remote + 11;
-	int remote_is_branch = starts_with(remote, "refs/heads/");
+	const char *shortname = skip_prefix(remote, refs_heads_prefix);
+	int remote_is_branch = starts_with(remote, refs_heads_prefix);
 	struct strbuf key = STRBUF_INIT;
 	int rebasing = should_setup_rebase(origin);

-- 
1.8.5.3

Michael Haggerty· Feb 27, 2014, 11:42 UTC · re: Dmitry S. Dolzhenko · lore

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

Dmitry,

Thanks for your patch.  Please see my comments below.

On 02/27/2014 12:13 PM, Dmitry S. Dolzhenko wrote:

> Change install_branch_config() function to use skip_prefix()
> for getting short name of remote branch.

English tweak suggestion:

Change THE install_branch_config() function to use skip_prefix() for getting THE short name of THE remote branch.

Show 30 quoted lines

> Signed-off-by: Dmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
> ---
>  branch.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/branch.c b/branch.c
> index 723a36b..310749b 100644
> --- a/branch.c
> +++ b/branch.c
> @@ -4,6 +4,8 @@
>  #include "remote.h"
>  #include "commit.h"
>  
> +static const char refs_heads_prefix[] = "refs/heads/";
> +
>  struct tracking {
>  	struct refspec spec;
>  	char *src;
> @@ -49,8 +51,8 @@ static int should_setup_rebase(const char *origin)
>  
>  void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
>  {
> -	const char *shortname = remote + 11;
> -	int remote_is_branch = starts_with(remote, "refs/heads/");
> +	const char *shortname = skip_prefix(remote, refs_heads_prefix);
> +	int remote_is_branch = starts_with(remote, refs_heads_prefix);
>  	struct strbuf key = STRBUF_INIT;
>  	int rebasing = should_setup_rebase(origin);
>  
>

If you look at what skip_prefix() and starts_with() do, I think you will find that you are doing too much work here.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/

David Kastrup· Feb 27, 2014, 12:05 UTC · re: Michael Haggerty · lore

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 12 quoted lines

> Dmitry,
>
> Thanks for your patch.  Please see my comments below.
>
> On 02/27/2014 12:13 PM, Dmitry S. Dolzhenko wrote:
>> Change install_branch_config() function to use skip_prefix()
>> for getting short name of remote branch.
>
> English tweak suggestion:
>
> Change THE install_branch_config() function to use skip_prefix()
> for getting THE short name of THE remote branch.

Change install_branch_config() to use skip_prefix() for getting the short name of the remote branch.

-- 
David Kastrup

Dmitry S. Dolzhenko· Feb 27, 2014, 13:05 UTC · re: Michael Haggerty · lore

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

Michael,

Thank you for your remarks.

> If you look at what skip_prefix() and starts_with() do, I think you will
> find that you are doing too much work here.

How about this one?

	const char *shortname = skip_prefix(remote, "refs/heads/");
	int remote_is_branch = shortname != NULL;