# gitk : Lines not showing up in diff

3 messages from 2006-03-07 to 2006-03-07. Participants: Jacob Kroon, Robert Fitzsimons, Paul Mackerras.
Thread: https://gitlist.dev/t/3593

## Jacob Kroon, 2006-03-07 19:43

Subject: gitk : Lines not showing up in diff
Message-ID: <440DE262.7020007@gmail.com>
URL: https://gitlist.dev/e/440DE262.7020007%40gmail.com

```
I "think" this is a bug in gitk:

If I have a textfile in which I remove or add a line that looks like 
"-----------...", it won't show up in the diff gitk produces. "cg-log" 
shows the line correctly being added or deleted.

I'm using gitk 1.2.4 (From Fedora, gitk-1.2.4-1.fc4)

//Jacob

```

## Robert Fitzsimons, 2006-03-07 20:46

Subject: [PATCH] gitk : fix missing lines when displaying diff.
Message-ID: <20060307204648.GA13620@localhost>
URL: https://gitlist.dev/e/20060307204648.GA13620%40localhost
In-Reply-To: <440DE262.7020007@gmail.com>

```
Lines which are added (removed) and begin with +++ (---) are not shown
correctly when displaying in the diff panel.

The +++ and --- lines are part of the diff header, with the +++
indicating the end of the header.

Signed-off-by: Robert Fitzsimons <robfitz@273k.net>


---

 gitk |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

d0da9f04cf565df64a954e1bfd4c5c0913b83322
diff --git a/gitk b/gitk
index f4c6624..5e3c34c 100755
--- a/gitk
+++ b/gitk
@@ -2595,8 +2595,10 @@ proc getblobdiffline {bdf ids} {
        set pad [string range "----------------------------------------" 1 $l]
        $ctext insert end "$pad $header $pad\n" filesep
        set diffinhdr 1
-    } elseif {[regexp {^(---|\+\+\+)} $line]} {
-       set diffinhdr 0
+    } elseif {$diffinhdr == 1 && [regexp {^(---|\+\+\+) } $line]} {
+       if {[regexp {^\+\+\+ } $line]} {
+           set diffinhdr 0
+       }
     } elseif {[regexp {^@@ -([0-9]+),([0-9]+) \+([0-9]+),([0-9]+) @@(.*)} \
                   $line match f1l f1c f2l f2c rest]} {
        $ctext insert end "$line\n" hunksep
--
1.2.3.g20d2

```

## Paul Mackerras, 2006-03-07 22:17

Subject: Re: [PATCH] gitk : fix missing lines when displaying diff.
Message-ID: <17422.1637.975579.478563@cargo.ozlabs.ibm.com>
URL: https://gitlist.dev/e/17422.1637.975579.478563%40cargo.ozlabs.ibm.com
In-Reply-To: <20060307204648.GA13620@localhost>

```
Robert Fitzsimons writes:

> Lines which are added (removed) and begin with +++ (---) are not shown
> correctly when displaying in the diff panel.
> 
> The +++ and --- lines are part of the diff header, with the +++
> indicating the end of the header.

Thanks for pointing out the easy fix.  I had been going to do
something much more complicated. :)

However, your patch didn't apply due to the whitespace being munged.
I committed an equivalent fix, but I took the opportunity to change
the [regexp] to a couple of [string compare]s as well.

Paul.

```