# gitweb.cgi bug - XML Parsing Error: not well-formed

3 messages from 2014-02-18 to 2014-02-18. Participants: Dongsheng Song, Andrew Keller.
Thread: https://gitlist.dev/t/35906

## Dongsheng Song, 2014-02-18 11:41

Subject: gitweb.cgi bug - XML Parsing Error: not well-formed
Message-ID: <CAE8XmWp3uTW7wGrVryC6ECTkkJRcc=ruC=B6PhOURGifnh90Sw@mail.gmail.com>
URL: https://gitlist.dev/e/CAE8XmWp3uTW7wGrVryC6ECTkkJRcc%3DruC%3DB6PhOURGifnh90Sw%40mail.gmail.com

```
Here is gitweb generated XHTML fragment:

<div class="patch" id="patch19">
<div class="diff header">diff --git a/RFC/2010/DRE-2010-004 RFC for
Update Synchronization Program &amp; Solve the Balance Adjustment
Issue v2.doc <a class="path"
href="/repo/git?p=DRE/Reference.git;a=blob;f=RFC/2010/DRE-2010-004+RFC+for+Update+Synchronization+Program+%26+Solve+the+Balance+Adjustment+Issue+v2.doc;h=3074448e2e68235e891ebd1301e6277d993973a5;hb=fbd4e74c867214062ad39282a899f1d14a2e89ba">b/RFC/2010/DRE-2010-004
RFC for Update Synchronization Program &amp; Solve the Balance
Adjustment Issue v2.doc</a></div>
<div class="diff extended_header">
new file mode 100644<span class="info"> (file)</span><br/>
index 0000000..<a class="hash"
href="/repo/git?p=DRE/Reference.git;a=blob;f=RFC/2010/DRE-2010-004+RFC+for+Update+Synchronization+Program+%26+Solve+the+Balance+Adjustment+Issue+v2.doc;h=3074448e2e68235e891ebd1301e6277d993973a5;hb=fbd4e74c867214062ad39282a899f1d14a2e89ba">3074448</a><br/>
Binary files /dev/null and b/RFC/2010/DRE-2010-004 RFC for Update
Synchronization Program & Solve the Balance Adjustment Issue v2.doc
differ<br/>
</div>
</div>

--
Dongsheng

```

## Andrew Keller, 2014-02-18 14:34

Subject: Re: gitweb.cgi bug - XML Parsing Error: not well-formed
Message-ID: <7A867C8D-4F20-44C2-BE16-7EF81E799998@kellerfarm.com>
URL: https://gitlist.dev/e/7A867C8D-4F20-44C2-BE16-7EF81E799998%40kellerfarm.com
In-Reply-To: <CAE8XmWp3uTW7wGrVryC6ECTkkJRcc=ruC=B6PhOURGifnh90Sw@mail.gmail.com>

```
On Feb 18, 2014, at 6:41 AM, Dongsheng Song <dongsheng.song@gmail.com> wrote:

> Here is gitweb generated XHTML fragment:
> 
> …

You're going to have to be more specific.

 - Andrew

```

## Dongsheng Song, 2014-02-18 14:57

Subject: Re: gitweb.cgi bug - XML Parsing Error: not well-formed
Message-ID: <CAE8XmWpvQrW0Us309teZ_E8hvJWS8ihaGhOsU94EkOjeypGzhg@mail.gmail.com>
URL: https://gitlist.dev/e/CAE8XmWpvQrW0Us309teZ_E8hvJWS8ihaGhOsU94EkOjeypGzhg%40mail.gmail.com
In-Reply-To: <7A867C8D-4F20-44C2-BE16-7EF81E799998@kellerfarm.com>

```
What's your mean ?

I think I had post enough information:

When I access https://xxx.info/repo/git?p=DRE/Reference.git;a=commitdiff;h=fbd4e74c867214062ad39282a899f1d14a2e89ba

Then gitweb.cgi generate invalid XHTML:


<div class="patch" id="patch19">
<div class="diff header">diff --git a/RFC/2010/DRE-2010-004 RFC for
Update Synchronization Program &amp; Solve the Balance Adjustment
Issue v2.doc <a class="path"
href="/repo/git?p=DRE/Reference.git;a=blob;f=RFC/2010/DRE-2010-004+RFC+for+Update+Synchronization+Program+%26+Solve+the+Balance+Adjustment+Issue+v2.doc;h=3074448e2e68235e891ebd1301e6277d993973a5;hb=fbd4e74c867214062ad39282a899f1d14a2e89ba">b/RFC/2010/DRE-2010-004
RFC for Update Synchronization Program &amp; Solve the Balance
Adjustment Issue v2.doc</a></div>
<div class="diff extended_header">
new file mode 100644<span class="info"> (file)</span><br/>
index 0000000..<a class="hash"
href="/repo/git?p=DRE/Reference.git;a=blob;f=RFC/2010/DRE-2010-004+RFC+for+Update+Synchronization+Program+%26+Solve+the+Balance+Adjustment+Issue+v2.doc;h=3074448e2e68235e891ebd1301e6277d993973a5;hb=fbd4e74c867214062ad39282a899f1d14a2e89ba">3074448</a><br/>
Binary files /dev/null and b/RFC/2010/DRE-2010-004 RFC for Update
Synchronization Program & Solve the Balance Adjustment Issue v2.doc
differ<br/>
</div>
</div>

The last 'Program & Solve' should be 'Program &amp; Solve'

Regards,
Dongsheng

On Tue, Feb 18, 2014 at 10:34 PM, Andrew Keller <andrew@kellerfarm.com> wrote:
> On Feb 18, 2014, at 6:41 AM, Dongsheng Song <dongsheng.song@gmail.com> wrote:
>
>> Here is gitweb generated XHTML fragment:
>>
>> …
>
> You're going to have to be more specific.
>
>  - Andrew
>

```