threads / patch / 35754

patch, 2 partsbuiltin/apply.c: reduce scope of variables

Subject: [PATCH 2/2] builtin/apply.c: reduce scope of variables

## tl;dr

One message between Jan 29, 2014 and Jan 29, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Elia Pinto· Jan 29, 2014, 13:30 UTC · lore
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 builtin/apply.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Show changes to builtin/apply.c +6 −6
diff --git a/builtin/apply.c b/builtin/apply.c
index b0d0986..a7e72d5 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -1943,13 +1943,7 @@ static int parse_chunk(char *buffer, unsigned long size, struct patch *patch)
 				       size - offset - hdrsize, patch);
 
 	if (!patchsize) {
-		static const char *binhdr[] = {
-			"Binary files ",
-			"Files ",
-			NULL,
-		};
 		static const char git_binary[] = "GIT binary patch\n";
-		int i;
 		int hd = hdrsize + offset;
 		unsigned long llen = linelen(buffer + hd, size - hd);
 
@@ -1965,6 +1959,12 @@ static int parse_chunk(char *buffer, unsigned long size, struct patch *patch)
 				patchsize = 0;
 		}
 		else if (!memcmp(" differ\n", buffer + hd + llen - 8, 8)) {
+			static const char *binhdr[] = {
+				"Binary files ",
+				"Files ",
+				NULL,
+			};
+			int i;
 			for (i = 0; binhdr[i]; i++) {
 				int len = strlen(binhdr[i]);
 				if (len < size - hd &&
-- 
1.7.10.4

← back to recent threads