# [PATCH] Makefile: add cppcheck target 2 messages from 2014-01-29 to 2014-01-29. Participants: Elia Pinto, Junio C Hamano. Thread: https://gitlist.dev/t/35750 ## Elia Pinto, 2014-01-29 11:02 Subject: [PATCH] Makefile: add cppcheck target Message-ID: <1390993371-2431-1-git-send-email-gitter.spiros@gmail.com> URL: https://gitlist.dev/e/1390993371-2431-1-git-send-email-gitter.spiros%40gmail.com ``` Add cppcheck target to Makefile. Cppcheck is a static analysis tool for C/C++ code. Cppcheck primarily detects the types of bugs that the compilers normally do not detect. It is an useful target for doing QA analysis. Signed-off-by: Elia Pinto --- Makefile | 6 ++++++ config.mak.in | 1 + 2 files changed, 7 insertions(+) diff --git a/Makefile b/Makefile index dddaf4f..1d25a70 100644 --- a/Makefile +++ b/Makefile @@ -2602,3 +2602,9 @@ cover_db: coverage-report cover_db_html: cover_db cover -report html -outputdir cover_db_html cover_db +### cppcheck static coverage analysis +# +.PHONY: cppcheck + +cppcheck: + cppcheck --enable=all -q $(top_srcdir) diff --git a/config.mak.in b/config.mak.in index e6a6d0f..86b95fb 100644 --- a/config.mak.in +++ b/config.mak.in @@ -22,3 +22,4 @@ docdir = @docdir@ mandir = @mandir@ htmldir = @htmldir@ +top_srcdir = @top_srcdir@ -- 1.7.10.4 ``` ## Junio C Hamano, 2014-01-29 18:26 Subject: Re: [PATCH] Makefile: add cppcheck target Message-ID: URL: https://gitlist.dev/e/xmqqeh3qk5ka.fsf%40gitster.dls.corp.google.com In-Reply-To: <1390993371-2431-1-git-send-email-gitter.spiros@gmail.com> ``` Elia Pinto writes: > Add cppcheck target to Makefile. Cppcheck is a static > analysis tool for C/C++ code. Cppcheck primarily detects > the types of bugs that the compilers normally do not detect. > It is an useful target for doing QA analysis. > > Signed-off-by: Elia Pinto > --- > Makefile | 6 ++++++ > config.mak.in | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/Makefile b/Makefile > index dddaf4f..1d25a70 100644 > --- a/Makefile > +++ b/Makefile > @@ -2602,3 +2602,9 @@ cover_db: coverage-report > cover_db_html: cover_db > cover -report html -outputdir cover_db_html cover_db > > +### cppcheck static coverage analysis > +# > +.PHONY: cppcheck > + > +cppcheck: > + cppcheck --enable=all -q $(top_srcdir) Why isn't this "."? In other words, why is the change to config.mak.in even necessary? > diff --git a/config.mak.in b/config.mak.in > index e6a6d0f..86b95fb 100644 > --- a/config.mak.in > +++ b/config.mak.in > @@ -22,3 +22,4 @@ docdir = @docdir@ > > mandir = @mandir@ > htmldir = @htmldir@ > +top_srcdir = @top_srcdir@ ```