# [PATCH 2/2] strbuf: make it clear that suffixcmp() should not be used for sorting

1 messages from 2013-11-04 to 2013-11-04. Participants: Christian Couder.
Thread: https://gitlist.dev/t/35274

## Christian Couder, 2013-11-04 20:42

Subject: [PATCH 2/2] strbuf: make it clear that suffixcmp() should not be used for sorting
Message-ID: <20131104204251.16987.42654.chriscool@tuxfamily.org>
URL: https://gitlist.dev/e/20131104204251.16987.42654.chriscool%40tuxfamily.org

```
Nobody sane uses suffixcmp() for anything but checking with zero,
but it is not very clear from the implementation that it should
not be used for any sorting.

So let's make it clear that the callers should not expect anything
but "does str have sfx as its suffix, yes or no?".

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 strbuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/strbuf.c b/strbuf.c
index 1170d01..9ba50de 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -16,7 +16,7 @@ int suffixcmp(const char *str, const char *suffix)
 	if (len < suflen)
 		return -1;
 	else
-		return strcmp(str + len - suflen, suffix);
+		return !!strcmp(str + len - suflen, suffix);
 }
 
 /*
-- 
1.8.4.1.576.g36ba827.dirty

```