threads / patch / 35145

patchhttp.c: Spell the null pointer as NULL

Subject: [PATCH] http.c: Spell the null pointer as NULL

## tl;dr

3 messages between Oct 15, 2013 and Oct 15, 2013. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ramsay Jones· Oct 15, 2013, 21:55 UTC · lore

Commit 1bbcc224 ("http: refactor options to http_get_*", 28-09-2013) changed the type of final 'options' argument of the http_get_file() function from an int to an 'struct http_get_options' pointer. However, it neglected to update the (single) call site. Since this call was passing '0' to that argument, it was (correctly) being interpreted as a null pointer. Change to argument to NULL.

Noticed by sparse. ("Using plain integer as NULL pointer")
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jonathan, Junio,

I'm a little puzzled by not having noticed this until this evening! ;-) Also, I note that maint@kernel.org != maint@repo.or.cz/jrn

ATB, Ramsay Jones

 http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to http.c +1 −1
diff --git a/http.c b/http.c
index 96d7578..b133ffd 100644
--- a/http.c
+++ b/http.c
@@ -1045,7 +1045,7 @@ static char *fetch_pack_index(unsigned char *sha1, const char *base_url)
 	strbuf_addf(&buf, "%s.temp", sha1_pack_index_name(sha1));
 	tmp = strbuf_detach(&buf, NULL);
 
-	if (http_get_file(url, tmp, 0) != HTTP_OK) {
+	if (http_get_file(url, tmp, NULL) != HTTP_OK) {
 		error("Unable to get pack index %s", url);
 		free(tmp);
 		tmp = NULL;

-- 
1.8.4
Jeff King· Oct 15, 2013, 22:03 UTC · re: Ramsay Jones · lore

Re: [PATCH] http.c: Spell the null pointer as NULL

On Tue, Oct 15, 2013 at 10:55:02PM +0100, Ramsay Jones wrote:
Show 6 quoted lines
> Commit 1bbcc224 ("http: refactor options to http_get_*", 28-09-2013)
> changed the type of final 'options' argument of the http_get_file()
> function from an int to an 'struct http_get_options' pointer.
> However, it neglected to update the (single) call site. Since this
> call was passing '0' to that argument, it was (correctly) being
> interpreted as a null pointer. Change to argument to NULL.

Thanks, patch is obviously correct (and the cause was just oversight on my part).

-Peff

← back to recent threads