threads / patch / 35138

patchconfig doc: user.signingkey is also used for signed commits

Subject: [PATCH] config doc: user.signingkey is also used for signed commits

## tl;dr

3 messages between Oct 14, 2013 and Oct 14, 2013. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Nicolas Vigier· Oct 14, 2013, 17:04 UTC · lore

The description of the user.signingkey option only mentioned its use
when creating a signed tag. Make it clear that is is also used when
creating signed commits.
---
 Documentation/config.txt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Show changes to Documentation/config.txt +5 −5

diff --git a/Documentation/config.txt b/Documentation/config.txt
index ec57a15..50c5add 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -2251,11 +2251,11 @@ user.name::
 	environment variables.  See linkgit:git-commit-tree[1].
 
 user.signingkey::
-	If linkgit:git-tag[1] is not selecting the key you want it to
-	automatically when creating a signed tag, you can override the
-	default selection with this variable.  This option is passed
-	unchanged to gpg's --local-user parameter, so you may specify a key
-	using any method that gpg supports.
+	If linkgit:git-tag[1] or linkgit:git-commit[1] is not selecting the
+	key you want it to automatically when creating a signed tag or
+	commit, you can override the default selection with this variable.
+	This option is passed unchanged to gpg's --local-user parameter,
+	so you may specify a key using any method that gpg supports.
 
 web.browser::
 	Specify a web browser that may be used by some commands.

-- 
1.8.4

Jonathan Nieder· Oct 14, 2013, 17:15 UTC · re: Nicolas Vigier · lore

Re: [PATCH] config doc: user.signingkey is also used for signed commits

Nicolas Vigier wrote:

Show 6 quoted lines

> The description of the user.signingkey option only mentioned its use
> when creating a signed tag. Make it clear that is is also used when
> creating signed commits.
> ---
>  Documentation/config.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Thanks. May we have your sign-off? (See Documentation/SubmittingPatches section 5 "Sign your work" for what this means.)

Nicolas Vigier· Oct 14, 2013, 17:22 UTC · re: Jonathan Nieder · lore

Re: [PATCH] config doc: user.signingkey is also used for signed commits

On Mon, 14 Oct 2013, Jonathan Nieder wrote:

Show 11 quoted lines

> Nicolas Vigier wrote:
> 
> > The description of the user.signingkey option only mentioned its use
> > when creating a signed tag. Make it clear that is is also used when
> > creating signed commits.
> > ---
> >  Documentation/config.txt | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Thanks.  May we have your sign-off?  (See Documentation/SubmittingPatches
> section 5 "Sign your work" for what this means.)

Oops, I forgot to add it :
Signed-off-by: Nicolas Vigier <boklm@mars-attacks.org>

Thanks