# [PATCH] Fix: Handle ampersand in branch names properly

1 messages from 2013-10-10 to 2013-10-10. Participants: Alexander Kurz.
Thread: https://gitlist.dev/t/35098

## Alexander Kurz, 2013-10-10 14:19

Subject: [PATCH] Fix: Handle ampersand in branch names properly
Message-ID: <5256B78B.6050801@heliocentris.com>
URL: https://gitlist.dev/e/5256B78B.6050801%40heliocentris.com

```
Hello git maintainer crew,
  recently I stumbled about gitweb generating improper HTML after 
somebody merged from a branch contining an ampersand, e.g. branch 
name=fixes&features.
  Thanks, Alexander Kurz


>From beccd85ba8b8421213056883f31365f33d6e4490 Mon Sep 17 00:00:00 2001
From: kurz <kurz@DP-KURZ.heliocentris.com>
Date: Thu, 10 Oct 2013 16:09:46 +0200
Subject: [PATCH] Fix: Handle ampersand in branch names properly

---
 gitweb/gitweb.perl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 68c77f6..2963b1d 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2026,7 +2026,7 @@ sub format_ref_marker {
 				-href => href(
 					action=>$dest_action,
 					hash=>$dest
-				)}, $name);
+				)}, esc_attr($name));
 
 			$markers .= " <span class=\"".esc_attr($class)."\" title=\"".esc_attr($ref)."\">" .
 				$link . "</span>";
-- 
1.7.10.4


```