threads / patch / 35073

patch, 6 partsrefs.c: Fix a sparse warning

Subject: [PATCH 2/6] refs.c: Fix a sparse warning

## tl;dr

One message between Oct 6, 2013 and Oct 6, 2013. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Oct 6, 2013, 20:49 UTC · lore

Sparse issues an "Using plain integer as NULL pointer" warning against a call to update_ref_lock() which passes '0' to the 'int *type_p' parameter. In order to suppress the warning, we simply change the argument to 'NULL'.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 refs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to refs.c +1 −1
diff --git a/refs.c b/refs.c
index ad5d66c..3710748 100644
--- a/refs.c
+++ b/refs.c
@@ -3235,7 +3235,7 @@ int update_ref(const char *action, const char *refname,
 	       int flags, enum action_on_err onerr)
 {
 	struct ref_lock *lock;
-	lock = update_ref_lock(refname, oldval, flags, 0, onerr);
+	lock = update_ref_lock(refname, oldval, flags, NULL, onerr);
 	if (!lock)
 		return 1;
 	return update_ref_write(action, refname, sha1, lock, onerr);
-- 
1.8.4

← back to recent threads