# [PATCH] sample pre-commit hook: Use --bool when retrieving config var 3 messages from 2013-09-24 to 2013-09-25. Participants: Johan Herland, Jonathan Nieder. Thread: https://gitlist.dev/t/35004 ## Johan Herland, 2013-09-24 07:52 Subject: [PATCH] sample pre-commit hook: Use --bool when retrieving config var Message-ID: <1380009176-10490-1-git-send-email-johan@herland.net> URL: https://gitlist.dev/e/1380009176-10490-1-git-send-email-johan%40herland.net ``` Signed-off-by: Johan Herland --- Resend/reminder... ...Johan templates/hooks--pre-commit.sample | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/hooks--pre-commit.sample b/templates/hooks--pre-commit.sample index 586e3bf..68d62d5 100755 --- a/templates/hooks--pre-commit.sample +++ b/templates/hooks--pre-commit.sample @@ -16,7 +16,7 @@ else fi # If you want to allow non-ASCII filenames set this variable to true. -allownonascii=$(git config hooks.allownonascii) +allownonascii=$(git config --bool hooks.allownonascii) # Redirect output to stderr. exec 1>&2 -- 1.8.1.rc2.269.g5aaac94 ``` ## Jonathan Nieder, 2013-09-24 19:22 Subject: Re: [PATCH] sample pre-commit hook: Use --bool when retrieving config var Message-ID: <20130924192259.GN9464@google.com> URL: https://gitlist.dev/e/20130924192259.GN9464%40google.com In-Reply-To: <1380009176-10490-1-git-send-email-johan@herland.net> ``` Johan Herland wrote: > Signed-off-by: Johan Herland Thanks. What symptoms does this alleviate? Is this to allow configurations like [hooks] allowNonAscii = 1 and [hooks] allowNonAscii to do the expected thing, or is it something more subtle than that? Curious, Jonathan ``` ## Johan Herland, 2013-09-25 10:10 Subject: Re: [PATCH] sample pre-commit hook: Use --bool when retrieving config var Message-ID: URL: https://gitlist.dev/e/CALKQrgc_5PhN-PsnCPnxcoN%2BzNKGo1CEJZw0CZzPXvu6aG23uA%40mail.gmail.com In-Reply-To: <20130924192259.GN9464@google.com> ``` On Tue, Sep 24, 2013 at 9:22 PM, Jonathan Nieder wrote: > Johan Herland wrote: >> Signed-off-by: Johan Herland > > Thanks. > > What symptoms does this alleviate? Is this to allow configurations like > > [hooks] > allowNonAscii = 1 > > and > > [hooks] > allowNonAscii > > to do the expected thing, or is it something more subtle than that? Nothing subtle. Just what you list. And for consistency with the other sample hooks' use of "git config". ...Johan -- Johan Herland, www.herland.net ```