# [PATCH] t7508: avoid non-portable sed expression

2 messages from 2013-09-14 to 2013-09-14. Participants: Eric Sunshine, Matthieu Moy.
Thread: https://gitlist.dev/t/34930

## Eric Sunshine, 2013-09-14 04:47

Subject: [PATCH] t7508: avoid non-portable sed expression
Message-ID: <1379134032-83211-1-git-send-email-sunshine@sunshineco.com>
URL: https://gitlist.dev/e/1379134032-83211-1-git-send-email-sunshine%40sunshineco.com

```
2556b996 (status: disable display of '#' comment prefix by default;
2013-09-06) introduced tests which fail on Mac OS X due to unportable
use of \t (for TAB) in a sed expression. POSIX [1][2] also disallows
it. Fix this.

[1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html#tag_20_116_13_02
[2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_03_02

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---

This applies against 'next'.

 t/t7508-status.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/t/t7508-status.sh b/t/t7508-status.sh
index 7d52dbf..6fb59f3 100755
--- a/t/t7508-status.sh
+++ b/t/t7508-status.sh
@@ -61,7 +61,8 @@ test_expect_success 'status (1)' '
 '
 
 strip_comments () {
-	sed "s/^\# //; s/^\#$//; s/^#\t/\t/" <"$1" >"$1".tmp &&
+	tab='	'
+	sed "s/^\# //; s/^\#$//; s/^#$tab/$tab/" <"$1" >"$1".tmp &&
 	rm "$1" && mv "$1".tmp "$1"
 }
 
-- 
1.8.4.535.g7b94f8e

```

## Matthieu Moy, 2013-09-14 17:50

Subject: Re: [PATCH] t7508: avoid non-portable sed expression
Message-ID: <vpqppsbe1hy.fsf@anie.imag.fr>
URL: https://gitlist.dev/e/vpqppsbe1hy.fsf%40anie.imag.fr
In-Reply-To: <1379134032-83211-1-git-send-email-sunshine@sunshineco.com>

```
Eric Sunshine <sunshine@sunshineco.com> writes:

>  strip_comments () {
> -	sed "s/^\# //; s/^\#$//; s/^#\t/\t/" <"$1" >"$1".tmp &&
> +	tab='	'
> +	sed "s/^\# //; s/^\#$//; s/^#$tab/$tab/" <"$1" >"$1".tmp &&

Sounds trivially right.

Sorry for breaking this.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

```