# [PATCH] sequencer: trivial cleanup 4 messages from 2013-09-08 to 2013-09-09. Participants: Ramkumar Ramachandra, Felipe Contreras, SZEDER Gábor. Thread: https://gitlist.dev/t/34883 ## Ramkumar Ramachandra, 2013-09-08 22:42 Subject: [PATCH] sequencer: trivial cleanup Message-ID: <1378680160-4720-1-git-send-email-artagnon@gmail.com> URL: https://gitlist.dev/e/1378680160-4720-1-git-send-email-artagnon%40gmail.com ``` Signed-off-by: Ramkumar Ramachandra --- sequencer.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sequencer.c b/sequencer.c index 351548f..8ed9f98 100644 --- a/sequencer.c +++ b/sequencer.c @@ -466,10 +466,7 @@ static int allow_empty(struct replay_opts *opts, struct commit *commit) empty_commit = is_original_commit_empty(commit); if (empty_commit < 0) return empty_commit; - if (!empty_commit) - return 0; - else - return 1; + return empty_commit ? 0 : 1; } static int do_pick_commit(struct commit *commit, struct replay_opts *opts) -- 1.8.4.100.gde18f6d.dirty ``` ## Felipe Contreras, 2013-09-08 22:53 Subject: Re: [PATCH] sequencer: trivial cleanup Message-ID: URL: https://gitlist.dev/e/CAMP44s1fE0XZScL_gU5JAEdC0hPFHPTovqXLx7gqvwVdZbBaVw%40mail.gmail.com In-Reply-To: <1378680160-4720-1-git-send-email-artagnon@gmail.com> ``` On Sun, Sep 8, 2013 at 5:42 PM, Ramkumar Ramachandra wrote: > Signed-off-by: Ramkumar Ramachandra > --- > sequencer.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/sequencer.c b/sequencer.c > index 351548f..8ed9f98 100644 > --- a/sequencer.c > +++ b/sequencer.c > @@ -466,10 +466,7 @@ static int allow_empty(struct replay_opts *opts, struct commit *commit) > empty_commit = is_original_commit_empty(commit); > if (empty_commit < 0) > return empty_commit; > - if (!empty_commit) > - return 0; > - else > - return 1; > + return empty_commit ? 0 : 1; > } Isn't it the other way around? Moreover, 'return !!empty_commit;' would be simpler. -- Felipe Contreras ``` ## Ramkumar Ramachandra, 2013-09-08 22:57 Subject: Re: [PATCH] sequencer: trivial cleanup Message-ID: URL: https://gitlist.dev/e/CALkWK0mx6dc0%3DYAwCPKSrCFqCAytOQXhSv36k1S_59sFr_bBWw%40mail.gmail.com In-Reply-To: ``` Felipe Contreras wrote: >> sequencer.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/sequencer.c b/sequencer.c >> index 351548f..8ed9f98 100644 >> --- a/sequencer.c >> +++ b/sequencer.c >> @@ -466,10 +466,7 @@ static int allow_empty(struct replay_opts *opts, struct commit *commit) >> empty_commit = is_original_commit_empty(commit); >> if (empty_commit < 0) >> return empty_commit; >> - if (!empty_commit) >> - return 0; >> - else >> - return 1; >> + return empty_commit ? 0 : 1; >> } > > Isn't it the other way around? Moreover, 'return !!empty_commit;' > would be simpler. Yeah, thanks for pointing out this grave stupidity. This seems to be inconsequential as far as the tests are concerned: have to do some major yak shaving. ``` ## SZEDER Gábor, 2013-09-09 00:20 Subject: Re: [PATCH] sequencer: trivial cleanup Message-ID: <20130909002026.GF28959@goldbirke> URL: https://gitlist.dev/e/20130909002026.GF28959%40goldbirke In-Reply-To: ``` Hi, On Sun, Sep 08, 2013 at 05:53:19PM -0500, Felipe Contreras wrote: > On Sun, Sep 8, 2013 at 5:42 PM, Ramkumar Ramachandra wrote: > > Signed-off-by: Ramkumar Ramachandra > > --- > > sequencer.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/sequencer.c b/sequencer.c > > index 351548f..8ed9f98 100644 > > --- a/sequencer.c > > +++ b/sequencer.c > > @@ -466,10 +466,7 @@ static int allow_empty(struct replay_opts *opts, struct commit *commit) > > empty_commit = is_original_commit_empty(commit); > > if (empty_commit < 0) > > return empty_commit; > > - if (!empty_commit) > > - return 0; > > - else > > - return 1; > > + return empty_commit ? 0 : 1; > > } > > Isn't it the other way around? Moreover, 'return !!empty_commit;' > would be simpler. Considering the possible return values from is_original_commit_empty(), I think all this could be written as return is_original_commit_empty(commit); Best, Gábor ```