threads / patch / 3475

patchgit-format-patch: Always add a blank line between headers and body.

Subject: [PATCH] git-format-patch: Always add a blank line between headers and body.

## tl;dr

One message between Feb 27, 2006 and Feb 27, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alexandre Julliard· Feb 27, 2006, 13:09 UTC · lore

If the second line of the commit message isn't empty, git-format-patch needs to add an empty line in order to generate a properly formatted mail. Otherwise git-rebase drops the rest of the commit message.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 git-format-patch.sh |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
dcd0ed6ced98990c92a32416c0acc3ec298f5b91
Show changes to git-format-patch.sh +6 −1
diff --git a/git-format-patch.sh b/git-format-patch.sh
index eb75de4..2bd2639 100755
--- a/git-format-patch.sh
+++ b/git-format-patch.sh
@@ -174,7 +174,7 @@ titleScript='
 process_one () {
 	perl -w -e '
 my ($keep_subject, $num, $signoff, $commsg) = @ARGV;
-my ($signoff_pattern, $done_header, $done_subject, $signoff_seen,
+my ($signoff_pattern, $done_header, $done_subject, $done_separator, $signoff_seen,
     $last_was_signoff);
 
 if ($signoff) {
@@ -228,6 +228,11 @@ while (<FH>) {
 	$done_subject = 1;
 	next;
     }
+    unless ($done_separator) {
+        print "\n";
+        $done_separator = 1;
+        next if (/^$/);
+    }
 
     $last_was_signoff = 0;
     if (/Signed-off-by:/i) {
-- 
1.2.3.gb348-dirty


-- 
Alexandre Julliard
julliard@winehq.org

← back to recent threads