threads / patch / 34748

patchDocumentation/fast-import: clarify summary for `feature` command

Subject: [PATCH] Documentation/fast-import: clarify summary for `feature` command

## tl;dr

2 messages between Aug 23, 2013 and Aug 25, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Matthieu Moy· Aug 23, 2013, 08:29 UTC · lore

In most cases, "feature <foo>" does not just require that the feature exists, but also changes the behavior to enable it.

Cases where the feature is only requested like cat-blob, notes or ls are clearly documented below.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 Documentation/git-fast-import.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to Documentation/git-fast-import.txt +2 −2
diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index bf1a02a..4a9cc74 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -361,8 +361,8 @@ and control the current import process.  More detailed discussion
 	`--cat-blob-fd` or `stdout` if unspecified.
 
 `feature`::
-	Require that fast-import supports the specified feature, or
-	abort if it does not.
+	Enable the specified feature. This requires that fast-import
+	supports the specified feature, and aborts if it does not.
 
 `option`::
 	Specify any of the options listed under OPTIONS that do not
-- 
1.8.4.rc4.4.g57d5d3d
Jonathan Nieder· Aug 25, 2013, 05:57 UTC · re: Matthieu Moy · lore

Re: [PATCH] Documentation/fast-import: clarify summary for `feature` command

Matthieu Moy wrote:
> In most cases, "feature <foo>" does not just require that the feature
> exists, but also changes the behavior to enable it.
For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

← back to recent threads