# [PATCH] log doc: the argument to --encoding is not optional 3 messages from 2013-08-02 to 2013-08-05. Participants: Jonathan Nieder, Junio C Hamano. Thread: https://gitlist.dev/t/34590 ## Jonathan Nieder, 2013-08-02 22:16 Subject: [PATCH] log doc: the argument to --encoding is not optional Message-ID: <20130802221640.GA7478@elie.Belkin> URL: https://gitlist.dev/e/20130802221640.GA7478%40elie.Belkin ``` $ git log --encoding fatal: Option '--encoding' requires a value $ git rev-list --encoding fatal: Option '--encoding' requires a value The argument to --encoding has always been mandatory. Unfortunately manpages like git-rev-list(1), git-log(1), and git-show(1) have described the option's syntax as "--encoding[=]" since it was first documented. Clarify by removing the extra brackets. Signed-off-by: Jonathan Nieder --- Documentation/git-rev-list.txt | 2 +- Documentation/pretty-options.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt index 65ac27e0..045b37b8 100644 --- a/Documentation/git-rev-list.txt +++ b/Documentation/git-rev-list.txt @@ -40,7 +40,7 @@ SYNOPSIS [ \--right-only ] [ \--cherry-mark ] [ \--cherry-pick ] - [ \--encoding[=] ] + [ \--encoding= ] [ \--(author|committer|grep)= ] [ \--regexp-ignore-case | -i ] [ \--extended-regexp | -E ] diff --git a/Documentation/pretty-options.txt b/Documentation/pretty-options.txt index 5e499421..eea0e306 100644 --- a/Documentation/pretty-options.txt +++ b/Documentation/pretty-options.txt @@ -28,7 +28,7 @@ people using 80-column terminals. This is a shorthand for "--pretty=oneline --abbrev-commit" used together. ---encoding[=]:: +--encoding=:: The commit objects record the encoding used for the log message in their encoding header; this option can be used to tell the command to re-code the commit log message in the encoding -- 1.8.4.rc1 ``` ## Junio C Hamano, 2013-08-05 15:20 Subject: Re: [PATCH] log doc: the argument to --encoding is not optional Message-ID: <7vob9cnp0f.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vob9cnp0f.fsf%40alter.siamese.dyndns.org In-Reply-To: <20130802221640.GA7478@elie.Belkin> ``` Jonathan Nieder writes: > $ git log --encoding > fatal: Option '--encoding' requires a value > $ git rev-list --encoding > fatal: Option '--encoding' requires a value > > The argument to --encoding has always been mandatory. Unfortunately > manpages like git-rev-list(1), git-log(1), and git-show(1) have > described the option's syntax as "--encoding[=]" since it > was first documented. Clarify by removing the extra brackets. > > Signed-off-by: Jonathan Nieder > --- Thanks. > Documentation/git-rev-list.txt | 2 +- > Documentation/pretty-options.txt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt > index 65ac27e0..045b37b8 100644 > --- a/Documentation/git-rev-list.txt > +++ b/Documentation/git-rev-list.txt > @@ -40,7 +40,7 @@ SYNOPSIS > [ \--right-only ] > [ \--cherry-mark ] > [ \--cherry-pick ] > - [ \--encoding[=] ] > + [ \--encoding= ] > [ \--(author|committer|grep)= ] > [ \--regexp-ignore-case | -i ] > [ \--extended-regexp | -E ] > diff --git a/Documentation/pretty-options.txt b/Documentation/pretty-options.txt > index 5e499421..eea0e306 100644 > --- a/Documentation/pretty-options.txt > +++ b/Documentation/pretty-options.txt > @@ -28,7 +28,7 @@ people using 80-column terminals. > This is a shorthand for "--pretty=oneline --abbrev-commit" > used together. > > ---encoding[=]:: > +--encoding=:: > The commit objects record the encoding used for the log message > in their encoding header; this option can be used to tell the > command to re-code the commit log message in the encoding ``` ## Junio C Hamano, 2013-08-05 15:50 Subject: Re: [PATCH] log doc: the argument to --encoding is not optional Message-ID: <7vzjswm91k.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vzjswm91k.fsf%40alter.siamese.dyndns.org In-Reply-To: <20130802221640.GA7478@elie.Belkin> ``` Thanks. ```