# [PATCH] Rename advice.object_name_warning to objectNameWarning 2 messages from 2013-07-31 to 2013-07-31. Participants: Thomas Rast, Junio C Hamano. Thread: https://gitlist.dev/t/34577 ## Thomas Rast, 2013-07-31 20:23 Subject: [PATCH] Rename advice.object_name_warning to objectNameWarning Message-ID: URL: https://gitlist.dev/e/bc52a7d4a5f1010e6813ddf503a0b84976dc55e4.1375301985.git.trast%40inf.ethz.ch ``` We spell config variables in camelCase instead of with_underscores. Signed-off-by: Thomas Rast --- I figure since we don't have the variable in any release yet *and* the worst possible outcome is that someone sees the advice message again, the consistency is worth the change. advice.c | 2 +- sha1_name.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/advice.c b/advice.c index 2a52098..3eca9f5 100644 --- a/advice.c +++ b/advice.c @@ -35,7 +35,7 @@ { "implicitidentity", &advice_implicit_identity }, { "detachedhead", &advice_detached_head }, { "setupstreamfailure", &advice_set_upstream_failure }, - { "object_name_warning", &advice_object_name_warning }, + { "objectnamewarning", &advice_object_name_warning }, { "rmhints", &advice_rm_hints }, /* make this an alias for backward compatibility */ diff --git a/sha1_name.c b/sha1_name.c index 1d210e3..852dd95 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -445,7 +445,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1) "\n" "where \"$br\" is somehow empty and a 40-hex ref is created. Please\n" "examine these refs and maybe delete them. Turn this message off by\n" - "running \"git config advice.object_name_warning false\""); + "running \"git config advice.objectNameWarning false\""); unsigned char tmp_sha1[20]; char *real_ref = NULL; int refs_found = 0; -- 1.8.4.rc0.408.gad6868d ``` ## Junio C Hamano, 2013-07-31 22:19 Subject: Re: [PATCH] Rename advice.object_name_warning to objectNameWarning Message-ID: <7vmwp2tls0.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmwp2tls0.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Thomas Rast writes: > We spell config variables in camelCase instead of with_underscores. > > Signed-off-by: Thomas Rast > --- > > I figure since we don't have the variable in any release yet *and* the > worst possible outcome is that someone sees the advice message again, > the consistency is worth the change. Thanks, I agree. > > advice.c | 2 +- > sha1_name.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/advice.c b/advice.c > index 2a52098..3eca9f5 100644 > --- a/advice.c > +++ b/advice.c > @@ -35,7 +35,7 @@ > { "implicitidentity", &advice_implicit_identity }, > { "detachedhead", &advice_detached_head }, > { "setupstreamfailure", &advice_set_upstream_failure }, > - { "object_name_warning", &advice_object_name_warning }, > + { "objectnamewarning", &advice_object_name_warning }, > { "rmhints", &advice_rm_hints }, > > /* make this an alias for backward compatibility */ > diff --git a/sha1_name.c b/sha1_name.c > index 1d210e3..852dd95 100644 > --- a/sha1_name.c > +++ b/sha1_name.c > @@ -445,7 +445,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1) > "\n" > "where \"$br\" is somehow empty and a 40-hex ref is created. Please\n" > "examine these refs and maybe delete them. Turn this message off by\n" > - "running \"git config advice.object_name_warning false\""); > + "running \"git config advice.objectNameWarning false\""); > unsigned char tmp_sha1[20]; > char *real_ref = NULL; > int refs_found = 0; ```