Incompatible '+=' syntax in git-completion.bash

Hi there,

I noticed a change in commit 734b2f0 on contrib/completion/git-completion.bash which reverted a syntax fix for '+=' syntax [1], the syntax does not work for bash < 3.1. As far as I know, bash 3.0.x is still widely used on some old servers, could someone add the fix back again?

Thanks, Matt

[1] https://github.com/git/git/commit/734b2f0532d847a9f566183982f83ddea8d8d197#commitcomment-3664571

Matthew Wang <mattwyl@gmail.com> writes:

Does anybody know of a reason why a[$#a+1]=$c notation should not be used for zsh? If there isn't, I think we should cherry-pick

    50c5885e (git-completion.bash: replace zsh notation that breaks
    bash 3.X, 2013-01-18)

by Brandon on top of 'master' or on 6bf931a5 (Merge branch 'fc/zsh-leftover-bits', 2013-06-02).

Thanks.

-- >8 --
From: Brandon Casey <drafnel@gmail.com>
Date: Fri, 18 Jan 2013 11:24:01 -0800
Subject: [PATCH] git-completion.bash: replace zsh notation that breaks bash 3.X

When commit d8b45314 began separating the zsh completion from the bash completion, it introduced a zsh completion "bridge" section into the bash completion script for zsh users to use until they migrated to the zsh script. The zsh '+=()' append-to-array notation prevents bash 3.00.15 on CentOS 4.x from loading the completion script and breaks test 9902. We can easily work around this by using standard Bash array notation.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)