threads / patch / 34505

patchFwd: [PATCH] Improve font rendering on retina macbooks

Subject: Fwd: [PATCH] Improve font rendering on retina macbooks

## tl;dr

3 messages between Jul 21, 2013 and Aug 27, 2013. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Mads Dørup· Jul 21, 2013, 12:25 UTC · lore

Hi there

I've created a very small change to git gui that considerably improves the experience on my machine at least:

Show changes to git-gui/macosx/Info.plist +2 −0

diff --git a/git-gui/macosx/Info.plist b/git-gui/macosx/Info.plist
index b3bf15f..1ade121 100644
--- a/git-gui/macosx/Info.plist
+++ b/git-gui/macosx/Info.plist
@@ -24,5 +24,7 @@
        <string>GITg</string>
        <key>CFBundleVersion</key>
        <string>@@GITGUI_VERSION@@</string>
+       <key>NSHighResolutionCapable</key>
+       <true/>
 </dict>
 </plist>


I've read the documentation for submitting patches to git where it
says that I have to e-mail the patch to the mail list, with relevant
developers as CC. Pat are you the relevant developer for this?

Here is a screenshot comparison of before and after the change:

https://github.com/git/git/pull/48

Please let me know how to proceed to get this patch in, if you like
it. I've never contributed here before, so please me know about any
procedures I have missed.

Regards, Mads Dørup

Mads Dørup· Jul 21, 2013, 22:48 UTC · re: Mads Dørup · lore

Re: [PATCH] Improve font rendering on retina macbooks

I've been asked to close the github pull request. So instead, to see before-and-after screenshots of this change have a look here:

https://github.com/cpius/git/commit/dce145c11a89be7c795815c9bd8fe2c07a5afa7d#commitcomment-3682422

Regards, Mads Dørup

On Sun, Jul 21, 2013 at 2:25 PM, Mads Dørup <mads@dorup.dk> wrote:

Show 32 quoted lines

> Hi there
>
> I've created a very small change to git gui that considerably improves
> the experience on my machine at least:
>
> diff --git a/git-gui/macosx/Info.plist b/git-gui/macosx/Info.plist
> index b3bf15f..1ade121 100644
> --- a/git-gui/macosx/Info.plist
> +++ b/git-gui/macosx/Info.plist
> @@ -24,5 +24,7 @@
>         <string>GITg</string>
>         <key>CFBundleVersion</key>
>         <string>@@GITGUI_VERSION@@</string>
> +       <key>NSHighResolutionCapable</key>
> +       <true/>
>  </dict>
>  </plist>
>
>
> I've read the documentation for submitting patches to git where it
> says that I have to e-mail the patch to the mail list, with relevant
> developers as CC. Pat are you the relevant developer for this?
>
> Here is a screenshot comparison of before and after the change:
>
> https://github.com/git/git/pull/48
>
> Please let me know how to proceed to get this patch in, if you like
> it. I've never contributed here before, so please me know about any
> procedures I have missed.
>
> Regards, Mads Dørup

Pat Thoyts· Aug 27, 2013, 19:10 UTC · lore

Re: [PATCH] Improve font rendering on retina macbooks

Mads Dørup <mads@dorup.dk> writes:

Show 32 quoted lines

>Hi there
>
>I've created a very small change to git gui that considerably improves the
>experience on my machine at least:
>
>diff --git a/git-gui/macosx/Info.plist b/git-gui/macosx/Info.plist
>index b3bf15f..1ade121 100644
>--- a/git-gui/macosx/Info.plist
>+++ b/git-gui/macosx/Info.plist
>@@ -24,5 +24,7 @@
>        <string>GITg</string>
>        <key>CFBundleVersion</key>
>        <string>@@GITGUI_VERSION@@</string>
>+       <key>NSHighResolutionCapable</key>
>+       <true/>
> </dict>
> </plist>
>
>
>I've read the documentation for submitting patches to git where it says that I
>have to e-mail the patch to the mail list, with relevant developers as CC. Pat
>are you the relevant developer for this?
>
>Here is a screenshot comparison of before and after the change:
>
>https://github.com/git/git/pull/48
>
>Please let me know how to proceed to get this patch in, if you like it. I've
>never contributed here before, so please me know about any procedures I have
>missed.
>
>Regards, Mads Dørup

Looks like it makes a big difference from those pictures. Patch applied. Thank you.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD