# [PATCH] t6131 - skip tests if on case-insensitive file system 3 messages from 2013-07-17 to 2013-07-17. Participants: Mark Levedahl, Duy Nguyen, Junio C Hamano. Thread: https://gitlist.dev/t/34454 ## Mark Levedahl, 2013-07-17 13:22 Subject: [PATCH] t6131 - skip tests if on case-insensitive file system Message-ID: <1374067336-6545-1-git-send-email-mlevedahl@gmail.com> URL: https://gitlist.dev/e/1374067336-6545-1-git-send-email-mlevedahl%40gmail.com ``` This test fails on Cygwin where the default system configuration does not support case sensitivity (only case retention), so don't run the test on such systems. Signed-off-by: Mark Levedahl --- t/t6131-pathspec-icase.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh index 3215eef..8d4a7fc 100755 --- a/t/t6131-pathspec-icase.sh +++ b/t/t6131-pathspec-icase.sh @@ -3,6 +3,12 @@ test_description='test case insensitive pathspec limiting' . ./test-lib.sh +if test_have_prereq CASE_INSENSITIVE_FS +then + skip_all='skipping case sensitive tests - case insensitive file system' + test_done +fi + test_expect_success 'create commits with glob characters' ' test_commit bar bar && test_commit bAr bAr && -- 1.8.3.2.0.63 ``` ## Duy Nguyen, 2013-07-17 13:42 Subject: Re: [PATCH] t6131 - skip tests if on case-insensitive file system Message-ID: URL: https://gitlist.dev/e/CACsJy8Ayyb7kTydXFxoeqNQgGemdUXXzAc3ZwEbT5dCuk_tkQA%40mail.gmail.com In-Reply-To: <1374067336-6545-1-git-send-email-mlevedahl@gmail.com> ``` On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl wrote: > This test fails on Cygwin where the default system configuration does not > support case sensitivity (only case retention), so don't run the test on > such systems. Yeah. I knew this when I wrote this test but forgot to put the check in. Thanks. We can re-enable the test later, as it does not really need case-insensitive filesystems. > > Signed-off-by: Mark Levedahl > --- > t/t6131-pathspec-icase.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh > index 3215eef..8d4a7fc 100755 > --- a/t/t6131-pathspec-icase.sh > +++ b/t/t6131-pathspec-icase.sh > @@ -3,6 +3,12 @@ > test_description='test case insensitive pathspec limiting' > . ./test-lib.sh > > +if test_have_prereq CASE_INSENSITIVE_FS > +then > + skip_all='skipping case sensitive tests - case insensitive file system' > + test_done > +fi > + > test_expect_success 'create commits with glob characters' ' > test_commit bar bar && > test_commit bAr bAr && > -- > 1.8.3.2.0.63 > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Duy ``` ## Junio C Hamano, 2013-07-17 19:47 Subject: Re: [PATCH] t6131 - skip tests if on case-insensitive file system Message-ID: <7vppuh55pb.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vppuh55pb.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Duy Nguyen writes: > On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl wrote: >> This test fails on Cygwin where the default system configuration does not >> support case sensitivity (only case retention), so don't run the test on >> such systems. > > Yeah. I knew this when I wrote this test but forgot to put the check > in. Thanks. We can re-enable the test later, as it does not really > need case-insensitive filesystems. Yeah, I tend to agree. You do not need to create case-colliding paths for the purpose of :(icase) tests. > >> >> Signed-off-by: Mark Levedahl >> --- >> t/t6131-pathspec-icase.sh | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh >> index 3215eef..8d4a7fc 100755 >> --- a/t/t6131-pathspec-icase.sh >> +++ b/t/t6131-pathspec-icase.sh >> @@ -3,6 +3,12 @@ >> test_description='test case insensitive pathspec limiting' >> . ./test-lib.sh >> >> +if test_have_prereq CASE_INSENSITIVE_FS >> +then >> + skip_all='skipping case sensitive tests - case insensitive file system' >> + test_done >> +fi >> + >> test_expect_success 'create commits with glob characters' ' >> test_commit bar bar && >> test_commit bAr bAr && >> -- >> 1.8.3.2.0.63 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe git" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > Duy ```