# [PATCH] builtin/push.c: use OPT_BOOL, not OPT_BOOLEAN 2 messages from 2013-07-08 to 2013-07-09. Participants: Junio C Hamano, Jonathan Nieder. Thread: https://gitlist.dev/t/34384 ## Junio C Hamano, 2013-07-08 21:59 Subject: [PATCH] builtin/push.c: use OPT_BOOL, not OPT_BOOLEAN Message-ID: <7vsizoyap9.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vsizoyap9.fsf%40alter.siamese.dyndns.org ``` The command line parser of "git push" for "--tags", "--delete", and "--thin" options still used outdated OPT_BOOLEAN. Because these options do not give escalating levels when given multiple times, they should use OPT_BOOL. Signed-off-by: Junio C Hamano --- builtin/push.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/push.c b/builtin/push.c index 2d84d10..342d792 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -427,15 +427,15 @@ int cmd_push(int argc, const char **argv, const char *prefix) OPT_BIT( 0 , "all", &flags, N_("push all refs"), TRANSPORT_PUSH_ALL), OPT_BIT( 0 , "mirror", &flags, N_("mirror all refs"), (TRANSPORT_PUSH_MIRROR|TRANSPORT_PUSH_FORCE)), - OPT_BOOLEAN( 0, "delete", &deleterefs, N_("delete refs")), - OPT_BOOLEAN( 0 , "tags", &tags, N_("push tags (can't be used with --all or --mirror)")), + OPT_BOOL( 0, "delete", &deleterefs, N_("delete refs")), + OPT_BOOL( 0 , "tags", &tags, N_("push tags (can't be used with --all or --mirror)")), OPT_BIT('n' , "dry-run", &flags, N_("dry run"), TRANSPORT_PUSH_DRY_RUN), OPT_BIT( 0, "porcelain", &flags, N_("machine-readable output"), TRANSPORT_PUSH_PORCELAIN), OPT_BIT('f', "force", &flags, N_("force updates"), TRANSPORT_PUSH_FORCE), { OPTION_CALLBACK, 0, "recurse-submodules", &flags, N_("check"), N_("control recursive pushing of submodules"), PARSE_OPT_OPTARG, option_parse_recurse_submodules }, - OPT_BOOLEAN( 0 , "thin", &thin, N_("use thin pack")), + OPT_BOOL( 0 , "thin", &thin, N_("use thin pack")), OPT_STRING( 0 , "receive-pack", &receivepack, "receive-pack", N_("receive pack program")), OPT_STRING( 0 , "exec", &receivepack, "receive-pack", N_("receive pack program")), OPT_BIT('u', "set-upstream", &flags, N_("set upstream for git pull/status"), -- 1.8.3.2-876-ge3d3f5e ``` ## Jonathan Nieder, 2013-07-09 00:29 Subject: Re: [PATCH] builtin/push.c: use OPT_BOOL, not OPT_BOOLEAN Message-ID: <20130709002934.GX408@google.com> URL: https://gitlist.dev/e/20130709002934.GX408%40google.com In-Reply-To: <7vsizoyap9.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano wrote: > The command line parser of "git push" for "--tags", "--delete", and > "--thin" options still used outdated OPT_BOOLEAN. Because these > options do not give escalating levels when given multiple times, > they should use OPT_BOOL. Thanks. Looks obviously correct, so Reviewed-by: Jonathan Nieder ```