gitview: Use monospace font to draw the branch and tag name

Aneesh Kumar K.V· Feb 22, 2006, 16:06 UTC · lore

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>

---

 contrib/gitview/gitview |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

725c7d29cbe4efd0a7f7d9f218dc12e36f5920de

diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview
index 5862fcc..0e52c78 100755
--- a/contrib/gitview/gitview
+++ b/contrib/gitview/gitview
@@ -174,9 +174,9 @@ class CellRendererGraph(gtk.GenericCellR
 		names_len = 0
 		if (len(names) != 0):
 			for item in names:
-				names_len += len(item)/3
+				names_len += len(item)
 
-		width = box_size * (cols + 1 + names_len )
+		width = box_size * (cols + 1 ) + names_len 
 		height = box_size
 
 		# FIXME I have no idea how to use cell_area properly
@@ -258,6 +258,8 @@ class CellRendererGraph(gtk.GenericCellR
 			for item in names:
 				name = name + item + " "
 
+			ctx.select_font_face("Monospace")
+			ctx.set_font_size(13)
 			ctx.text_path(name)
 
 		self.set_colour(ctx, colour, 0.0, 0.5)
@@ -537,8 +539,8 @@ class GitView:
 
 		cell = CellRendererGraph()
 		column = gtk.TreeViewColumn()
-		column.set_resizable(False)
-		column.pack_start(cell, expand=False)
+		column.set_resizable(True)
+		column.pack_start(cell, expand=True)
 		column.add_attribute(cell, "node", 1)
 		column.add_attribute(cell, "in-lines", 2)
 		column.add_attribute(cell, "out-lines", 3)

-- 
1.2.0-dirty

Junio C Hamano· Feb 24, 2006, 11:17 UTC · re: Aneesh Kumar K.V · lore

Re: gitview: Use monospace font to draw the branch and tag name

"Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:

> This patch address the below:
> Use monospace font to draw branch and tag name
> set the font size to 13.

Aneesh Kumar· Feb 24, 2006, 16:29 UTC · re: Junio C Hamano · lore

Re: gitview: Use monospace font to draw the branch and tag name

On 2/24/06, Junio C Hamano <junkio@cox.net> wrote:

> "Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:
>
> > This patch address the below:
> > Use monospace font to draw branch and tag name
> > set the font size to 13.
>
> I have an impression that hardcoding UI policy like this is
> generally frowned upon.

But with that changes branch and the tag name looks neat.

-aneesh

Junio C Hamano· Feb 25, 2006, 06:05 UTC · re: Aneesh Kumar · lore

Re: gitview: Use monospace font to draw the branch and tag name

"Aneesh Kumar" <aneesh.kumar@gmail.com> writes:

> On 2/24/06, Junio C Hamano <junkio@cox.net> wrote:
>> "Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:
>>
>> > This patch address the below:
>> > Use monospace font to draw branch and tag name
>> > set the font size to 13.
>>
>> I have an impression that hardcoding UI policy like this is
>> generally frowned upon.
>
> But with that changes branch and the tag name looks neat.

Aneesh Kumar· Feb 25, 2006, 07:00 UTC · re: Junio C Hamano · lore

Re: gitview: Use monospace font to draw the branch and tag name

On 2/25/06, Junio C Hamano <junkio@cox.net> wrote:

>
> >> I have an impression that hardcoding UI policy like this is
> >> generally frowned upon.
> >
> > But with that changes branch and the tag name looks neat.
>
> The point being that it only looks neat on your display, with
> its size and resolution, and to your eye.
>
> People have different tastes and equipments.  One thing I really
> liked gitk (I do not know if gitview does this as well -- if so
> I am happy) is I can do - and + to change the text size
> depending on what display I am working on.
>
>

-aneesh