# [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls

2 messages from 2013-07-03 to 2013-07-03. Participants: Matthieu Moy, Junio C Hamano.
Thread: https://gitlist.dev/t/34333

## Matthieu Moy, 2013-07-03 09:14

Subject: [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls
Message-ID: <1372842859-16598-1-git-send-email-Matthieu.Moy@imag.fr>
URL: https://gitlist.dev/e/1372842859-16598-1-git-send-email-Matthieu.Moy%40imag.fr

```
Commit e83d36b66fc turned "print STDOUT" into "print {*STDOUT}", as
suggested by perlcritic. Unfortunately, it also changed two "binmode
STDOUT" calls the same way, which does not work and yield a "Not a GLOB
reference" error.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 contrib/mw-to-git/git-remote-mediawiki.perl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index e40c034..f8d7d2c 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -576,9 +576,9 @@ sub literal_data_raw {
 	my ($content) = @_;
 	# Avoid confusion between size in bytes and in characters
 	utf8::downgrade($content);
-	binmode {*STDOUT}, ':raw';
+	binmode STDOUT, ':raw';
 	print {*STDOUT} 'data ', bytes::length($content), "\n", $content;
-	binmode {*STDOUT}, ':encoding(UTF-8)';
+	binmode STDOUT, ':encoding(UTF-8)';
 	return;
 }
 
-- 
1.8.3.1.495.g13f33cf.dirty

```

## Junio C Hamano, 2013-07-03 19:10

Subject: Re: [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls
Message-ID: <7v8v1nfoif.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v8v1nfoif.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1372842859-16598-1-git-send-email-Matthieu.Moy@imag.fr>

```
Thanks.

```