# [PATCH] perf-lib: fix start/stop of perf tests 3 messages from 2013-06-29 to 2013-06-30. Participants: Thomas Gummerer, Thomas Rast, Junio C Hamano. Thread: https://gitlist.dev/t/34306 ## Thomas Gummerer, 2013-06-29 13:38 Subject: [PATCH] perf-lib: fix start/stop of perf tests Message-ID: <1372513119-27384-1-git-send-email-t.gummerer@gmail.com> URL: https://gitlist.dev/e/1372513119-27384-1-git-send-email-t.gummerer%40gmail.com ``` ae75342 test-lib: rearrange start/end of test_expect_* and test_skip changed the way tests are started/stopped, but did not update the perf tests. They were therefore giving the wrong output, because of the wrong test count. Fix this by starting and stopping the tests correctly. Signed-off-by: Thomas Gummerer --- t/perf/perf-lib.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index a816fbc..c61d535 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -150,6 +150,7 @@ exit $ret' >&3 2>&4 test_perf () { + test_start_ test "$#" = 3 && { test_prereq=$1; shift; } || test_prereq= test "$#" = 2 || error "bug in the test script: not 2 or 3 parameters to test-expect-success" @@ -187,7 +188,7 @@ test_perf () { base="$perf_results_dir"/"$perf_results_prefix$(basename "$0" .sh)"."$test_count" "$TEST_DIRECTORY"/perf/min_time.perl test_time.* >"$base".times fi - echo >&3 "" + test_finish_ } # We extend test_done to print timings at the end (./run disables this -- 1.8.3.453.g1dfc63d ``` ## Thomas Rast, 2013-06-29 16:51 Subject: Re: [PATCH] perf-lib: fix start/stop of perf tests Message-ID: <87ppv4hnbt.fsf@linux-k42r.v.cablecom.net> URL: https://gitlist.dev/e/87ppv4hnbt.fsf%40linux-k42r.v.cablecom.net In-Reply-To: <1372513119-27384-1-git-send-email-t.gummerer@gmail.com> ``` Thomas Gummerer writes: > ae75342 test-lib: rearrange start/end of test_expect_* and test_skip > changed the way tests are started/stopped, but did not update the perf > tests. They were therefore giving the wrong output, because of the > wrong test count. Fix this by starting and stopping the tests > correctly. > > Signed-off-by: Thomas Gummerer Doh! Thanks for catching this. > t/perf/perf-lib.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh > index a816fbc..c61d535 100644 > --- a/t/perf/perf-lib.sh > +++ b/t/perf/perf-lib.sh > @@ -150,6 +150,7 @@ exit $ret' >&3 2>&4 > > > test_perf () { > + test_start_ > test "$#" = 3 && { test_prereq=$1; shift; } || test_prereq= > test "$#" = 2 || > error "bug in the test script: not 2 or 3 parameters to test-expect-success" > @@ -187,7 +188,7 @@ test_perf () { > base="$perf_results_dir"/"$perf_results_prefix$(basename "$0" .sh)"."$test_count" > "$TEST_DIRECTORY"/perf/min_time.perl test_time.* >"$base".times > fi > - echo >&3 "" > + test_finish_ > } > > # We extend test_done to print timings at the end (./run disables this -- Thomas Rast trast@{inf,student}.ethz.ch ``` ## Junio C Hamano, 2013-06-30 01:46 Subject: Re: [PATCH] perf-lib: fix start/stop of perf tests Message-ID: <7vbo6ol6ar.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbo6ol6ar.fsf%40alter.siamese.dyndns.org In-Reply-To: <87ppv4hnbt.fsf@linux-k42r.v.cablecom.net> ``` Thanks, both. Will queue. ```