threads / patch / 34246

patchgit-remote-hg: Fix . at end of ref

Subject: [PATCH] git-remote-hg: Fix . at end of ref

## tl;dr

One message between Jun 21, 2013 and Jun 21, 2013. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Brian Gernhardt· Jun 21, 2013, 16:12 UTC · lore

Any Mercurial tag/branch/bookmark that ended with a period would be rejected by fast-import. The repository could be cloned, but any further fetch would fail.

Use a similar trick to the space handling, but only when the period is at the end of the ref.

Probably need a more general solution to this problem.
Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---
 contrib/remote-helpers/git-remote-hg | 2 ++
 1 file changed, 2 insertions(+)
Show changes to contrib/remote-helpers/git-remote-hg +2 −0
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 0194c67..7fa6cd7 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -78,9 +78,11 @@ def hgbin(n):
     return node.bin(n)
 
 def hgref(ref):
+    ref = re.sub('_\._$', '.', ref)
     return ref.replace('___', ' ')
 
 def gitref(ref):
+    ref = re.sub('\.$', '_._', ref)
     return ref.replace(' ', '___')
 
 def check_version(*check):
-- 
1.8.3.1.636.g893104c

← back to recent threads