threads / discuss / 3418

PATCH: fix git-fmt-merge-msg on ActiveState Perl

Subject: PATCH: fix git-fmt-merge-msg on ActiveState Perl

## tl;dr

3 messages between Feb 21, 2006 and Feb 21, 2006.

replies: 2people: 1as markdown or json

Alex Riesen· Feb 21, 2006, 15:45 UTC · lore

For people who stuck with ActiveState Perl, as there seem to be no chance for it to support the list form of "open" in foreseeable future.

Working it around again. Should be harmless, as there are only sha1s passed

--- @#$%^&* windows!!!

>From nobody Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Tue Feb 21 15:53:39 2006 +0100
Subject: fix git-fmt-merge-msg on activestate perl
---
 git-fmt-merge-msg.perl |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
65ca8f2e90b9816c1748847fc406d26a56b7ad2d
diff --git a/git-fmt-merge-msg.perl b/git-fmt-merge-msg.perl
index 9071312..f4ecd13 100755
--- a/git-fmt-merge-msg.perl
+++ b/git-fmt-merge-msg.perl
@@ -33,7 +33,7 @@ sub repoconfig {
 	my $fh;
 	my $val;
 	eval {
-		open $fh, '-|', 'git-repo-config', '--get', 'merge.summary'
+		open($fh, 'git-repo-config --get  merge.summary |')
 		    or die "$!";
 		($val) = <$fh>;
 		close $fh;
@@ -43,7 +43,7 @@ sub repoconfig {
 
 sub current_branch {
 	my $fh;
-	open $fh, '-|', 'git-symbolic-ref', 'HEAD' or die "$!";
+	open($fh, 'git-symbolic-ref HEAD |') or die "$!";
 	my ($bra) = <$fh>;
 	chomp($bra);
 	$bra =~ s|^refs/heads/||;
@@ -59,8 +59,7 @@ sub current_branch {
 sub shortlog {
 	my ($tip) = @_;
 	my ($fh, @result);
-	open $fh, '-|', ('git-log', '--topo-order',
-			 '--pretty=oneline', $tip, '^HEAD')
+	open($fh, "git-log --topo-order --pretty=oneline $tip ^HEAD |")
 	    or die "$!";
 	while (<$fh>) {
 		s/^[0-9a-f]{40}\s+//;
-- 
1.2.2.g65ca8
Alex Riesen· Feb 21, 2006, 15:48 UTC · re: Alex Riesen · lore

Re: PATCH: fix git-fmt-merge-msg on ActiveState Perl

On 2/21/06, Alex Riesen <raa.lkml@gmail.com> wrote:
> For people who stuck with ActiveState Perl, as there seem to be
> no chance for it to support the list form of "open" in foreseeable future.
Too late... Sorry :)
Alex Riesen· Feb 21, 2006, 22:18 UTC · re: Alex Riesen · lore

Re: PATCH: fix git-fmt-merge-msg on ActiveState Perl

Alex Riesen, Tue, Feb 21, 2006 16:48:43 +0100:
Show 5 quoted lines
> On 2/21/06, Alex Riesen <raa.lkml@gmail.com> wrote:
> > For people who stuck with ActiveState Perl, as there seem to be
> > no chance for it to support the list form of "open" in foreseeable future.
> 
> Too late... Sorry :)
Not too late, actually. It'll work for everyone with ActiveState Perl

← back to recent threads