threads / patch / 34153

patch, 2 partsAdd missing calls to git_config()

Subject: [PATCH 0/2] Add missing calls to git_config()

## tl;dr

One message between Jun 15, 2013 and Jun 15, 2013. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Jun 15, 2013, 20:28 UTC · lore
Hi Junio,

I recently had need to use the '-c' option to git in order to set some config variables from the command line; specifically with 'git show-ref' and 'git pack-refs'. I haven't looked to see if any other commands need similar attention, but:

    $ git grep 'cmd_.*(int argc' -- builtin | wc -l
    109
    $ git grep 'git_config(' -- builtin | wc -l
    80
    $
... maybe. ;-)

[I did think about separating the command line processing from the config file processing; maybe some commands could accept config settings from the command line, but do not need/want the regular config file processing? *dunno*.]

ATB, Ramsay Jones

Ramsay Jones (2):
  show-ref.c: Add missing call to git_config()
  pack-refs.c: Add missing call to git_config()
 builtin/pack-refs.c | 3 +++
 builtin/show-ref.c  | 2 ++
 2 files changed, 5 insertions(+)
-- 
1.8.3

← back to recent threads