git-send-email doesn't deal with quoted names

Jason A. Donenfeld· May 27, 2013, 23:40 UTC · lore

Hi,

My commit author name is "Jason A. Donenfeld". Because this has a dot, SMTP handling likes to put it in quotes.

git-send-email has this line:
            if (defined $author and $author ne $sender) {

With my name, this always winds up false, because it's comparing '"Jason A. Donenfeld" <Jason@zx2c4.com>' with 'Jason A. Donenfeld <Jason@zx2c4.com>'.

So, the logic needs to be fixed somehow.

Thanks, Jason

John Keeping· May 28, 2013, 08:25 UTC · re: Jason A. Donenfeld · lore

Re: git-send-email doesn't deal with quoted names

On Tue, May 28, 2013 at 01:40:20AM +0200, Jason A. Donenfeld wrote:

Show 11 quoted lines

> My commit author name is "Jason A. Donenfeld". Because this has a dot,
> SMTP handling likes to put it in quotes.
> 
> git-send-email has this line:
>             if (defined $author and $author ne $sender) {
> 
> With my name, this always winds up false, because it's comparing
> '"Jason A. Donenfeld" <Jason@zx2c4.com>' with 'Jason A. Donenfeld
> <Jason@zx2c4.com>'.
> 
> So, the logic needs to be fixed somehow.

There was a patch for this recently, although it appears to be still under discussion:

    http://article.gmane.org/gmane.comp.version-control.git/225247