threads / patch / 339

patchcg-mkpatch: Show diffstat before the patch

Subject: [PATCH] cg-mkpatch: Show diffstat before the patch

## tl;dr

4 messages between Apr 26, 2005 and Apr 28, 2005. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Jonas Fonseca· Apr 26, 2005, 22:58 UTC · lore

Show diffstat before the patch.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>

--- commit a738ed98e4557877f8bcd3b992aa55579b22b9d1 tree 2447d3a399200c8f736344822969f88f675612dd parent ed095b1a965517f1674b812a9978c60eb907e192 author Jonas Fonseca <fonseca@diku.dk> 1114554627 +0200 committer Jonas Fonseca <fonseca@diku.dk> 1114554627 +0200

 cg-mkpatch |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)

Show changes to diff +4 −1

Index: cg-mkpatch
===================================================================
--- 6159f313b10f0cfcdfedd63d6fb044029fe46aaa/cg-mkpatch  (mode:100755 sha1:5ba423cbbb3e5f72cd7fb74f2873d49b60557f12)
+++ 2447d3a399200c8f736344822969f88f675612dd/cg-mkpatch  (mode:100755 sha1:25c67a29296730daeac00e43fd4c18cf914a1c87)
@@ -23,7 +23,10 @@
 		echo $line >>$header
 	done
 	echo
-	cg-diff -p -r $id
+	cg-diff -p -r $id > $header
+	cat $header | diffstat
+	echo
+	cat $header
 	rm $header
 }

-- 
Jonas Fonseca

Petr Baudis· Apr 27, 2005, 23:55 UTC · re: Jonas Fonseca · lore

Re: [PATCH] cg-mkpatch: Show diffstat before the patch

Dear diary, on Wed, Apr 27, 2005 at 12:58:55AM CEST, I got a letter where Jonas Fonseca <fonseca@diku.dk> told me that...

> Show diffstat before the patch.
> 
> Signed-off-by: Jonas Fonseca <fonseca@diku.dk>

I think you should first check by which(1) or something whether you have diffstat. Piling up dependencies like this is pretty annoying.

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

YOSHIFUJI Hideaki / 吉藤英明· Apr 28, 2005, 00:07 UTC · re: Jonas Fonseca · lore

Re: [PATCH] cg-mkpatch: Show diffstat before the patch

In article <20050426225855.GA28560@diku.dk> (at Wed, 27 Apr 2005 00:58:55 +0200), Jonas Fonseca <fonseca@diku.dk> says:

> Show diffstat before the patch.

We do not always need to generate diffstat. Please add -s option or something to prepend diffstat. Thanks.

--yoshfuji

Petr Baudis· Apr 28, 2005, 00:16 UTC · re: YOSHIFUJI Hideaki / 吉藤英明 · lore

Re: [PATCH] cg-mkpatch: Show diffstat before the patch

Dear diary, on Thu, Apr 28, 2005 at 02:07:02AM CEST, I got a letter where "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org> told me that...

Show 7 quoted lines

> In article <20050426225855.GA28560@diku.dk> (at Wed, 27 Apr 2005 00:58:55 +0200), Jonas Fonseca <fonseca@diku.dk> says:
> 
> > Show diffstat before the patch.
> 
> We do not always need to generate diffstat.
> Please add -s option or something to prepend diffstat.
> Thanks.

Actually, I've been thinking about something like -s, but as in "short", which would skip this --- part altogether.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor