# [PATCH] Document push --no-verify

5 messages from 2013-05-22 to 2013-05-23. Participants: Thomas Rast, Junio C Hamano, Michael S. Tsirkin.
Thread: https://gitlist.dev/t/33896

## Thomas Rast, 2013-05-22 09:23

Subject: [PATCH] Document push --no-verify
Message-ID: <bac9440ba0c977f6bd4207ac423f82b716947cc0.1369214470.git.trast@inf.ethz.ch>
URL: https://gitlist.dev/e/bac9440ba0c977f6bd4207ac423f82b716947cc0.1369214470.git.trast%40inf.ethz.ch

```
ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
add a note to git-push(1) about the new --no-verify option.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
---

The insertion spot is at the end, because the existing ordering is
indistinguishable from random.  This should also be fixed, but is a
much bigger change and probably not suitable for an -rc period.


 Documentation/git-push.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index d514813..426b3d2 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt
@@ -11,7 +11,7 @@ SYNOPSIS
 [verse]
 'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
 	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
-	   [<repository> [<refspec>...]]
+	   [--no-verify] [<repository> [<refspec>...]]
 
 DESCRIPTION
 -----------
@@ -195,6 +195,9 @@ useful if you write an alias or script around 'git push'.
 	be pushed. If on-demand was not able to push all necessary
 	revisions it will also be aborted and exit with non-zero status.
 
+--no-verify::
+	Bypass the pre-push hook (see linkgit:githooks[5]).
+
 
 include::urls-remotes.txt[]
 
-- 
1.8.3.rc3.490.g2f233b5

```

## Junio C Hamano, 2013-05-22 17:17

Subject: Re: [PATCH] Document push --no-verify
Message-ID: <7vli77j5nm.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vli77j5nm.fsf%40alter.siamese.dyndns.org
In-Reply-To: <bac9440ba0c977f6bd4207ac423f82b716947cc0.1369214470.git.trast@inf.ethz.ch>

```
Thomas Rast <trast@inf.ethz.ch> writes:

> ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
> add a note to git-push(1) about the new --no-verify option.

Does it take --verify option (that may well be the default) so that
somebody with

         [alias] put = push --no-verify

can say "git put --verify args..."?

>
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
> ---
>
> The insertion spot is at the end, because the existing ordering is
> indistinguishable from random.  This should also be fixed, but is a
> much bigger change and probably not suitable for an -rc period.
>
>
>  Documentation/git-push.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index d514813..426b3d2 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -11,7 +11,7 @@ SYNOPSIS
>  [verse]
>  'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
>  	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
> -	   [<repository> [<refspec>...]]
> +	   [--no-verify] [<repository> [<refspec>...]]
>  
>  DESCRIPTION
>  -----------
> @@ -195,6 +195,9 @@ useful if you write an alias or script around 'git push'.
>  	be pushed. If on-demand was not able to push all necessary
>  	revisions it will also be aborted and exit with non-zero status.
>  
> +--no-verify::
> +	Bypass the pre-push hook (see linkgit:githooks[5]).
> +
>  
>  include::urls-remotes.txt[]

```

## Thomas Rast, 2013-05-22 20:23

Subject: Re: [PATCH] Document push --no-verify
Message-ID: <87vc6arcf4.fsf@linux-k42r.v.cablecom.net>
URL: https://gitlist.dev/e/87vc6arcf4.fsf%40linux-k42r.v.cablecom.net
In-Reply-To: <7vli77j5nm.fsf@alter.siamese.dyndns.org>

```
Junio C Hamano <gitster@pobox.com> writes:

> Thomas Rast <trast@inf.ethz.ch> writes:
>
>> ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
>> add a note to git-push(1) about the new --no-verify option.
>
> Does it take --verify option (that may well be the default) so that
> somebody with
>
>          [alias] put = push --no-verify
>
> can say "git put --verify args..."?

Yes.  Doesn't parse-options implicitly do the correct negation for all
boolean options, even those that are declared in their negative form?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

```

## Thomas Rast, 2013-05-23 13:34

Subject: [PATCH v2] Document push --no-verify
Message-ID: <ba24ea6f9fedc05690ee93a805d4f468650a942c.1369315855.git.trast@inf.ethz.ch>
URL: https://gitlist.dev/e/ba24ea6f9fedc05690ee93a805d4f468650a942c.1369315855.git.trast%40inf.ethz.ch
In-Reply-To: <87vc6arcf4.fsf@linux-k42r.v.cablecom.net>

```
ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
add a note to git-push(1) about the new --no-verify option.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
---

Junio replied privately that it should also mention the --verify
possibility.

So why not.  But this needs to be fixed across the board eventually;
0f1930c (parse-options: allow positivation of options starting, with
no-, 2012-02-25) did not update any docs, so none of the other --no-
options mention their positive forms.


 Documentation/git-push.txt | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index d514813..df5be26 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt
@@ -11,7 +11,7 @@ SYNOPSIS
 [verse]
 'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
 	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
-	   [<repository> [<refspec>...]]
+	   [--no-verify] [<repository> [<refspec>...]]
 
 DESCRIPTION
 -----------
@@ -195,6 +195,11 @@ useful if you write an alias or script around 'git push'.
 	be pushed. If on-demand was not able to push all necessary
 	revisions it will also be aborted and exit with non-zero status.
 
+--[no-]verify::
+	Toggle the pre-push hook (see linkgit:githooks[5]).  The
+	default is \--verify, giving the hook a chance to prevent the
+	push.  With \--no-verify, the hook is bypassed completely.
+
 
 include::urls-remotes.txt[]
 
-- 
1.8.3.rc3.486.gfe16094

```

## Michael S. Tsirkin, 2013-05-23 14:37

Subject: Re: [PATCH v2] Document push --no-verify
Message-ID: <20130523143711.GA24037@redhat.com>
URL: https://gitlist.dev/e/20130523143711.GA24037%40redhat.com
In-Reply-To: <ba24ea6f9fedc05690ee93a805d4f468650a942c.1369315855.git.trast@inf.ethz.ch>

```
On Thu, May 23, 2013 at 03:34:11PM +0200, Thomas Rast wrote:
> ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
> add a note to git-push(1) about the new --no-verify option.
> 
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>


Thanks. FWIW

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> 
> Junio replied privately that it should also mention the --verify
> possibility.
> 
> So why not.  But this needs to be fixed across the board eventually;
> 0f1930c (parse-options: allow positivation of options starting, with
> no-, 2012-02-25) did not update any docs, so none of the other --no-
> options mention their positive forms.
> 
> 
>  Documentation/git-push.txt | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index d514813..df5be26 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -11,7 +11,7 @@ SYNOPSIS
>  [verse]
>  'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
>  	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
> -	   [<repository> [<refspec>...]]
> +	   [--no-verify] [<repository> [<refspec>...]]
>  
>  DESCRIPTION
>  -----------
> @@ -195,6 +195,11 @@ useful if you write an alias or script around 'git push'.
>  	be pushed. If on-demand was not able to push all necessary
>  	revisions it will also be aborted and exit with non-zero status.
>  
> +--[no-]verify::
> +	Toggle the pre-push hook (see linkgit:githooks[5]).  The
> +	default is \--verify, giving the hook a chance to prevent the
> +	push.  With \--no-verify, the hook is bypassed completely.
> +
>  
>  include::urls-remotes.txt[]
>  
> -- 
> 1.8.3.rc3.486.gfe16094

```