# [PATCH] remote-hg: set stdout to binary mode on win32 3 messages from 2013-05-19 to 2013-05-20. Participants: Felipe Contreras, Junio C Hamano. Thread: https://gitlist.dev/t/33871 ## Felipe Contreras, 2013-05-19 11:53 Subject: [PATCH] remote-hg: set stdout to binary mode on win32 Message-ID: <1368964428-1059-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1368964428-1059-1-git-send-email-felipe.contreras%40gmail.com ``` From: Amit Bakshi git clone hangs on windows, and file.write would return errno 22 inside of mercurial's windows.winstdout wrapper class. This patch sets stdout's mode to binary, fixing both issues. Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index beb864b..01555dc 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -954,6 +954,10 @@ def main(args): marks_path = os.path.join(dirname, 'marks-hg') marks = Marks(marks_path) + if sys.platform == 'win32': + import msvcrt + msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY) + parser = Parser(repo) for line in parser: if parser.check('capabilities'): -- 1.8.3.rc3.286.g3d43083 ``` ## Felipe Contreras, 2013-05-19 12:00 Subject: Re: [PATCH] remote-hg: set stdout to binary mode on win32 Message-ID: URL: https://gitlist.dev/e/CAMP44s32tF01P5%3DGo%2Bcdh8x8m9c0c5e%3DSR4jpx_Zi38yQrGk7w%40mail.gmail.com In-Reply-To: <1368964428-1059-1-git-send-email-felipe.contreras@gmail.com> ``` On Sun, May 19, 2013 at 6:53 AM, Felipe Contreras wrote: > From: Amit Bakshi > > git clone hangs on windows, and file.write would return errno 22 inside > of mercurial's windows.winstdout wrapper class. This patch sets stdout's > mode to binary, fixing both issues. Forgot: [fc: cleaned up] > Signed-off-by: Felipe Contreras -- Felipe Contreras ``` ## Junio C Hamano, 2013-05-20 18:18 Subject: Re: [PATCH] remote-hg: set stdout to binary mode on win32 Message-ID: <7vehd1v7k7.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vehd1v7k7.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Felipe Contreras writes: > On Sun, May 19, 2013 at 6:53 AM, Felipe Contreras > wrote: >> From: Amit Bakshi >> >> git clone hangs on windows, and file.write would return errno 22 inside >> of mercurial's windows.winstdout wrapper class. This patch sets stdout's >> mode to binary, fixing both issues. > > Forgot: > [fc: cleaned up] > >> Signed-off-by: Felipe Contreras Thanks, sounds like this is meant for 'master'? ```