# gitk patch display corner-case bug

3 messages from 2006-02-18 to 2006-02-19. Participants: Karl Hasselström, Paul Mackerras.
Thread: https://gitlist.dev/t/3387

## Karl Hasselström, 2006-02-18 23:36

Subject: gitk patch display corner-case bug
Message-ID: <20060218233618.GA29025@diana.vm.bytemark.co.uk>
URL: https://gitlist.dev/e/20060218233618.GA29025%40diana.vm.bytemark.co.uk

```
In a recently updated stgit tree,

  $ git-diff 51cb39db\^ 51cb39db
  diff --git a/templates/covermail.tmpl b/templates/covermail.tmpl
  index 9789c9c..44cd19e 100644
  --- a/templates/covermail.tmpl
  +++ b/templates/covermail.tmpl
  @@ -4,5 +4,5 @@ Date: %(date)s
   %(endofheaders)s
   The following series implements...
   
  ---
  +-- 
   Signature

That is, a trailing whitespace was added after the two dashes.
However, gitk displays this as

  index 9789c9c..44cd19e 100644
  @@ -2,7 +2,7 @@ From: %(maintainer)s
   Subject: [PATCH%(version)s%(number)s] Series short description
   Date: %(date)s
   %(endofheaders)s
   The following series implements...
   
  +-- 
   Signature

Totally correct except that it omitted the line consisting of only
three dashes.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

```

## Paul Mackerras, 2006-02-19 11:06

Subject: Re: gitk patch display corner-case bug
Message-ID: <17400.20764.131417.903578@cargo.ozlabs.ibm.com>
URL: https://gitlist.dev/e/17400.20764.131417.903578%40cargo.ozlabs.ibm.com
In-Reply-To: <20060218233618.GA29025@diana.vm.bytemark.co.uk>

```
Karl Hasselström writes:

> Totally correct except that it omitted the line consisting of only
> three dashes.

Could you check that the missing line is present in the output from
git-rev-list --header --parents --topo-order please?

Paul.

```

## Karl Hasselström, 2006-02-19 14:38

Subject: Re: gitk patch display corner-case bug
Message-ID: <20060219143857.GA5268@diana.vm.bytemark.co.uk>
URL: https://gitlist.dev/e/20060219143857.GA5268%40diana.vm.bytemark.co.uk
In-Reply-To: <17400.20764.131417.903578@cargo.ozlabs.ibm.com>

```
On 2006-02-19 22:06:04 +1100, Paul Mackerras wrote:

> Karl Hasselström writes:
>
> > Totally correct except that it omitted the line consisting of only
> > three dashes.
>
> Could you check that the missing line is present in the output from
> git-rev-list --header --parents --topo-order please?

I'm not sure I follow you. The affected commit is listed first by
"git-rev-list --header --parents --topo-order 51cb39db", but that
commad doesn't show diffs, so the missing line is not there.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

```