threads / patch / 33838

patchremote-bzr: fix cloning of non-listable repos

Subject: [PATCH] remote-bzr: fix cloning of non-listable repos

## tl;dr

2 messages between May 16, 2013 and May 16, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Felipe Contreras· May 16, 2013, 10:04 UTC · lore

Commit 95b0c60 (remote-bzr: add support for bzr repos) introduced a regression by assuming all bzr remote repos are listable, but they are not.

If they are not listable they are basically useless, so let's assume there is no bzr repo.

Reported-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
We want this on master for v1.8.3.
 contrib/remote-helpers/git-remote-bzr | 3 +++
 1 file changed, 3 insertions(+)
Show changes to contrib/remote-helpers/git-remote-bzr +3 −0
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index b295dd4..ad42317 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -840,6 +840,9 @@ def get_repo(url, alias):
 
     try:
         repo = origin.open_repository()
+        if not repo.user_transport.listable():
+            # this repository is not usable for us
+            raise bzrlib.errors.NoRepositoryPresent(repo.bzrdir)
     except bzrlib.errors.NoRepositoryPresent:
         # branch
 
-- 
1.8.3.rc2.542.g24820ba
Junio C Hamano· May 16, 2013, 16:29 UTC · re: Felipe Contreras · lore

Re: [PATCH] remote-bzr: fix cloning of non-listable repos

Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 12 quoted lines
> Commit 95b0c60 (remote-bzr: add support for bzr repos) introduced a
> regression by assuming all bzr remote repos are listable, but they are
> not.
>
> If they are not listable they are basically useless, so let's assume
> there is no bzr repo.
>
> Reported-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>
> We want this on master for v1.8.3.
Sure.
Show 17 quoted lines
>
>  contrib/remote-helpers/git-remote-bzr | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index b295dd4..ad42317 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -840,6 +840,9 @@ def get_repo(url, alias):
>  
>      try:
>          repo = origin.open_repository()
> +        if not repo.user_transport.listable():
> +            # this repository is not usable for us
> +            raise bzrlib.errors.NoRepositoryPresent(repo.bzrdir)
>      except bzrlib.errors.NoRepositoryPresent:
>          # branch

← back to recent threads