# [PATCH] remote-bzr: fix for disappeared revisions 3 messages from 2013-05-07 to 2013-05-08. Participants: Felipe Contreras, Junio C Hamano. Thread: https://gitlist.dev/t/33745 ## Felipe Contreras, 2013-05-07 23:39 Subject: [PATCH] remote-bzr: fix for disappeared revisions Message-ID: <1367969975-4163-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1367969975-4163-1-git-send-email-felipe.contreras%40gmail.com ``` It's possible that the previous tip goes away, we should not assume it's always present. Fortunately we are only using it to calculate the progress to display to the user, so only that needs to be fixed. Also, add a test that triggers this issue. Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 15 ++++++++++---- contrib/remote-helpers/test-bzr.sh | 37 +++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 4 deletions(-) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index 0ef30f8..3e452af 100755 --- a/contrib/remote-helpers/git-remote-bzr +++ b/contrib/remote-helpers/git-remote-bzr @@ -282,9 +282,13 @@ def export_branch(repo, name): branch.lock_read() revs = branch.iter_merge_sorted_revisions(None, tip, 'exclude', 'forward') - tip_revno = branch.revision_id_to_revno(tip) - last_revno, _ = branch.last_revision_info() - total = last_revno - tip_revno + try: + tip_revno = branch.revision_id_to_revno(tip) + last_revno, _ = branch.last_revision_info() + total = last_revno - tip_revno + except bzrlib.errors.NoSuchRevision: + tip_revno = 0 + total = 0 for revid, _, seq, _ in revs: @@ -353,7 +357,10 @@ def export_branch(repo, name): progress = (revno - tip_revno) if (progress % 100 == 0): - print "progress revision %d '%s' (%d/%d)" % (revno, name, progress, total) + if total: + print "progress revision %d '%s' (%d/%d)" % (revno, name, progress, total) + else: + print "progress revision %d '%s' (%d)" % (revno, name, progress) branch.unlock() diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh index cec55f1..3f417ad 100755 --- a/contrib/remote-helpers/test-bzr.sh +++ b/contrib/remote-helpers/test-bzr.sh @@ -300,4 +300,41 @@ test_expect_success 'proper bzr repo' ' test_cmp ../expected actual ' +test_expect_success 'strip' ' + mkdir -p tmp && cd tmp && + test_when_finished "cd .. && rm -rf tmp" && + + ( + bzr init bzrrepo && + cd bzrrepo && + + echo one >> content && + bzr add content && + bzr commit -m one && + + echo two >> content && + bzr commit -m two + ) && + + git clone "bzr::$PWD/bzrrepo" gitrepo && + + ( + cd bzrrepo && + bzr uncommit --force && + + echo three >> content && + bzr commit -m three && + + echo four >> content && + bzr commit -m four && + bzr log --line | sed -e "s/^[0-9]\+: //" > ../expected + ) && + + (cd gitrepo && + git fetch && + git log --format="%an %ad %s" --date=short origin/master > ../actual) && + + test_cmp actual expected +' + test_done -- 1.8.3.rc1.553.gac13664 ``` ## Felipe Contreras, 2013-05-07 23:42 Subject: Re: [PATCH] remote-bzr: fix for disappeared revisions Message-ID: URL: https://gitlist.dev/e/CAMP44s2j%2Bf9vNu45vo0PSr6KEwhvaLUY%2BN1SU95PkQvKq6nB%2Bw%40mail.gmail.com In-Reply-To: <1367969975-4163-1-git-send-email-felipe.contreras@gmail.com> ``` On Tue, May 7, 2013 at 6:39 PM, Felipe Contreras wrote: > + (cd gitrepo && > + git fetch && > + git log --format="%an %ad %s" --date=short origin/master > ../actual) && > + > + test_cmp actual expected Hmm: test_cmp expected actual -- Felipe Contreras ``` ## Junio C Hamano, 2013-05-08 05:16 Subject: Re: [PATCH] remote-bzr: fix for disappeared revisions Message-ID: <7v1u9ihx0v.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v1u9ihx0v.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Felipe Contreras writes: > On Tue, May 7, 2013 at 6:39 PM, Felipe Contreras > wrote: > >> + (cd gitrepo && >> + git fetch && >> + git log --format="%an %ad %s" --date=short origin/master > ../actual) && >> + >> + test_cmp actual expected > > Hmm: > > test_cmp expected actual Yeah, right. ```