# [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively 2 messages from 2013-05-06 to 2013-05-06. Participants: John Keeping, Junio C Hamano. Thread: https://gitlist.dev/t/33732 ## John Keeping, 2013-05-06 12:35 Subject: [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively Message-ID: <6bb37f45280373b96c2ae581db9bd87007dc0fb7.1367843730.git.john@keeping.me.uk> URL: https://gitlist.dev/e/6bb37f45280373b96c2ae581db9bd87007dc0fb7.1367843730.git.john%40keeping.me.uk ``` Commit 54bb901 (t/Makefile: fix result handling with TEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined TEST_RESULTS_DIRECTORY relative to itself, when it should be relative to TEST_OUTPUT_DIRECTORY. Fix this. Signed-off-by: John Keeping --- t/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/Makefile b/t/Makefile index 11de5da..ebb7371 100644 --- a/t/Makefile +++ b/t/Makefile @@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test TEST_LINT ?= test-lint-duplicates test-lint-executable ifdef TEST_OUTPUT_DIRECTORY -TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results +TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results else TEST_RESULTS_DIRECTORY = test-results endif -- 1.8.3.rc0.149.g98a72f2.dirty ``` ## Junio C Hamano, 2013-05-06 15:20 Subject: Re: [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively Message-ID: <7vy5bsrv73.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vy5bsrv73.fsf%40alter.siamese.dyndns.org In-Reply-To: <6bb37f45280373b96c2ae581db9bd87007dc0fb7.1367843730.git.john@keeping.me.uk> ``` John Keeping writes: > Commit 54bb901 (t/Makefile: fix result handling with > TEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined > TEST_RESULTS_DIRECTORY relative to itself, when it should be relative to > TEST_OUTPUT_DIRECTORY. Fix this. > > Signed-off-by: John Keeping > --- > t/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, I missed this one. > diff --git a/t/Makefile b/t/Makefile > index 11de5da..ebb7371 100644 > --- a/t/Makefile > +++ b/t/Makefile > @@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test > TEST_LINT ?= test-lint-duplicates test-lint-executable > > ifdef TEST_OUTPUT_DIRECTORY > -TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results > +TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results > else > TEST_RESULTS_DIRECTORY = test-results > endif ```