threads / patch / 33705

v2, 2 partsRemove the CYGWIN_V15_WIN32API build variable

Subject: [PATCH v2 0/2] Remove the CYGWIN_V15_WIN32API build variable

## tl;dr

3 messages between May 2, 2013 and May 2, 2013. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ramsay Jones· May 2, 2013, 19:23 UTC · lore
Hi Junio,
Version 2 changes:
   - minor edit to commit message to Patch #1
     (s.%s/NATIVE_WINDOWS/.%s/WINDOWS_NATIVE/.) ;-)
   - add some additional explanation to commit message
     of Patch #2.
Note: Since I don't have a commit ID for the first patch,
I didn't know how to refer to it in the second patch.

ATB, Ramsay Jones

Jonathan Nieder (1):
  mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIVE
Ramsay Allan Jones (1):
  cygwin: Remove the CYGWIN_V15_WIN32API build variable
 Makefile          |  7 -------
 abspath.c         |  2 +-
 compat/cygwin.c   |  5 -----
 compat/terminal.c |  4 ++--
 compat/win32.h    |  2 +-
 config.mak.uname  |  1 -
 diff-no-index.c   |  2 +-
 git-compat-util.h |  3 ++-
 help.c            |  2 +-
 run-command.c     | 10 +++++-----
 test-chmtime.c    |  2 +-
 thread-utils.c    |  2 +-
 12 files changed, 15 insertions(+), 27 deletions(-)
-- 
1.8.2
Junio C Hamano· May 2, 2013, 20:41 UTC · re: Ramsay Jones · lore

Re: [PATCH v2 0/2] Remove the CYGWIN_V15_WIN32API build variable

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 7 quoted lines
> Version 2 changes:
>
>    - minor edit to commit message to Patch #1
>      (s.%s/NATIVE_WINDOWS/.%s/WINDOWS_NATIVE/.) ;-)
>
>    - add some additional explanation to commit message
>      of Patch #2.
Thanks.
> Note: Since I don't have a commit ID for the first patch,
> I didn't know how to refer to it in the second patch.

At least we know that it will be applied on top of the other one, so what I usually do in such a case is to say "Now the previous one fixed that glitch, we can do X, Y and Z to make the world a better place on top of it."

Fredrik Gustafsson· May 2, 2013, 20:52 UTC · re: Ramsay Jones · lore

Re: [PATCH v2 0/2] Remove the CYGWIN_V15_WIN32API build variable

On Thu, May 02, 2013 at 08:23:53PM +0100, Ramsay Jones wrote:
> 
> Hi Junio,
> 

I'm not sure if this is a request that's valid or not. But for me it would be appriciated if you could send patch-series as a reply to the first e-mail in the patch-series. The way git send-email does.

That is: If your first e-mail has the header "Message-Id: X" all following e-mails in the same patch-serie has the header "In-Reply-To: X" set.

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com

← back to recent threads