# [PATCH] completion: add missiong format-patch options

4 messages from 2013-04-27 to 2013-04-27. Participants: Felipe Contreras, Junio C Hamano.
Thread: https://gitlist.dev/t/33655

## Felipe Contreras, 2013-04-27 20:17

Subject: [PATCH] completion: add missiong format-patch options
Message-ID: <1367093864-9362-1-git-send-email-felipe.contreras@gmail.com>
URL: https://gitlist.dev/e/1367093864-9362-1-git-send-email-felipe.contreras%40gmail.com

```
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index bc3fc9e..78aa4cc 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1314,11 +1314,12 @@ _git_fetch ()
 }
 
 __git_format_patch_options="
-	--stdout --attach --no-attach --thread --thread= --output-directory
+	--stdout --attach --no-attach --thread --thread= --no-thread
 	--numbered --start-number --numbered-files --keep-subject --signoff
 	--signature --no-signature --in-reply-to= --cc= --full-index --binary
 	--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=
 	--inline --suffix= --ignore-if-in-upstream --subject-prefix=
+	--output-directory --reroll-count --to= --cc= --quiet --notes
 "
 
 _git_format_patch ()
-- 
1.8.2.1.1031.g2ee5873

```

## Felipe Contreras, 2013-04-27 20:20

Subject: Re: [PATCH] completion: add missiong format-patch options
Message-ID: <CAMP44s2btC+y4Mmg_UgY1WU6NHGzNS-pQ2yagXBXtu35ukXtog@mail.gmail.com>
URL: https://gitlist.dev/e/CAMP44s2btC%2By4Mmg_UgY1WU6NHGzNS-pQ2yagXBXtu35ukXtog%40mail.gmail.com
In-Reply-To: <1367093864-9362-1-git-send-email-felipe.contreras@gmail.com>

```
Yeah, s/missiong/missing/

-- 
Felipe Contreras

```

## Junio C Hamano, 2013-04-27 21:36

Subject: Re: [PATCH] completion: add missiong format-patch options
Message-ID: <7vy5c3slkh.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vy5c3slkh.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1367093864-9362-1-git-send-email-felipe.contreras@gmail.com>

```
Looks like a no-brainer-safe update that could even go to maint.  I
prefer not to have too many patches in the "trivially correct"
category in flight, so will apply directly on top of 'master'.

Thanks.

```

## Felipe Contreras, 2013-04-27 21:39

Subject: Re: [PATCH] completion: add missiong format-patch options
Message-ID: <CAMP44s0g05L4GamAqbV-s9WJUsrcQeMK+N=c_jjzDMo3rQQ-Kw@mail.gmail.com>
URL: https://gitlist.dev/e/CAMP44s0g05L4GamAqbV-s9WJUsrcQeMK%2BN%3Dc_jjzDMo3rQQ-Kw%40mail.gmail.com
In-Reply-To: <7vy5c3slkh.fsf@alter.siamese.dyndns.org>

```
On Sat, Apr 27, 2013 at 4:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Looks like a no-brainer-safe update that could even go to maint.  I
> prefer not to have too many patches in the "trivially correct"
> category in flight, so will apply directly on top of 'master'.

I just noticed that --cc= is duplicated, not that it would make any
functional difference.

Cheers.

-- 
Felipe Contreras

```
