# [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS 4 messages from 2013-04-27 to 2013-04-29. Participants: Ramsay Jones, Jonathan Nieder, Junio C Hamano. Thread: https://gitlist.dev/t/33651 ## Ramsay Jones, 2013-04-27 19:40 Subject: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS Message-ID: <517C29BE.6050002@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/517C29BE.6050002%40ramsay1.demon.co.uk ``` From: Jonathan Nieder Throughout git, it is assumed that the WIN32 preprocessor symbol is defined on native Windows setups (mingw and msvc) and not on Cygwin. On Cygwin, most of the time git can pretend this is just another Unix machine, and Windows-specific magic is generally counterproductive. Unfortunately Cygwin *does* define the WIN32 symbol in some headers. Best to rely on a new git-specific symbol GIT_NATIVE_WINDOWS instead, defined as follows: #if defined(WIN32) && !defined(__CYGWIN__) # define GIT_NATIVE_WINDOWS #endif After this change, it should be possible to drop the CYGWIN_V15_WIN32API setting without any negative effect. [rj: %s/NATIVE_WINDOWS/GIT_NATIVE_WINDOWS/g ] Signed-off-by: Jonathan Nieder Signed-off-by: Ramsay Jones --- abspath.c | 2 +- compat/terminal.c | 4 ++-- compat/win32.h | 2 +- diff-no-index.c | 2 +- git-compat-util.h | 3 ++- help.c | 2 +- run-command.c | 10 +++++----- test-chmtime.c | 2 +- thread-utils.c | 2 +- 9 files changed, 15 insertions(+), 14 deletions(-) diff --git a/abspath.c b/abspath.c index 40cdc46..64adbe2 100644 --- a/abspath.c +++ b/abspath.c @@ -216,7 +216,7 @@ const char *absolute_path(const char *path) const char *prefix_filename(const char *pfx, int pfx_len, const char *arg) { static char path[PATH_MAX]; -#ifndef WIN32 +#ifndef GIT_WINDOWS_NATIVE if (!pfx_len || is_absolute_path(arg)) return arg; memcpy(path, pfx, pfx_len); diff --git a/compat/terminal.c b/compat/terminal.c index 9b5e3d1..313897d 100644 --- a/compat/terminal.c +++ b/compat/terminal.c @@ -3,7 +3,7 @@ #include "sigchain.h" #include "strbuf.h" -#if defined(HAVE_DEV_TTY) || defined(WIN32) +#if defined(HAVE_DEV_TTY) || defined(GIT_WINDOWS_NATIVE) static void restore_term(void); @@ -53,7 +53,7 @@ error: return -1; } -#elif defined(WIN32) +#elif defined(GIT_WINDOWS_NATIVE) #define INPUT_PATH "CONIN$" #define OUTPUT_PATH "CONOUT$" diff --git a/compat/win32.h b/compat/win32.h index 8ce9104..a97e880 100644 --- a/compat/win32.h +++ b/compat/win32.h @@ -2,7 +2,7 @@ #define WIN32_H /* common Win32 functions for MinGW and Cygwin */ -#ifndef WIN32 /* Not defined by Cygwin */ +#ifndef GIT_WINDOWS_NATIVE /* Not defined for Cygwin */ #include #endif diff --git a/diff-no-index.c b/diff-no-index.c index 74da659..e66fdf3 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -45,7 +45,7 @@ static int get_mode(const char *path, int *mode) if (!path || !strcmp(path, "/dev/null")) *mode = 0; -#ifdef _WIN32 +#ifdef GIT_WINDOWS_NATIVE else if (!strcasecmp(path, "nul")) *mode = 0; #endif diff --git a/git-compat-util.h b/git-compat-util.h index e955bb5..eeed506 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -85,13 +85,14 @@ #define _NETBSD_SOURCE 1 #define _SGI_SOURCE 1 -#ifdef WIN32 /* Both MinGW and MSVC */ +#if defined(WIN32) && !defined(__CYGWIN__) /* Both MinGW and MSVC */ # if defined (_MSC_VER) # define _WIN32_WINNT 0x0502 # endif #define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */ #include #include +#define GIT_WINDOWS_NATIVE #endif #include diff --git a/help.c b/help.c index 02ba043..3d70d7a 100644 --- a/help.c +++ b/help.c @@ -106,7 +106,7 @@ static int is_executable(const char *name) !S_ISREG(st.st_mode)) return 0; -#if defined(WIN32) || defined(__CYGWIN__) +#if defined(GIT_WINDOWS_NATIVE) || defined(__CYGWIN__) #if defined(__CYGWIN__) if ((st.st_mode & S_IXUSR) == 0) #endif diff --git a/run-command.c b/run-command.c index 1b32a12..aece872 100644 --- a/run-command.c +++ b/run-command.c @@ -72,7 +72,7 @@ static inline void close_pair(int fd[2]) close(fd[1]); } -#ifndef WIN32 +#ifndef GIT_WINDOWS_NATIVE static inline void dup_devnull(int to) { int fd = open("/dev/null", O_RDWR); @@ -159,7 +159,7 @@ static const char **prepare_shell_cmd(const char **argv) die("BUG: shell command is empty"); if (strcspn(argv[0], "|&;<>()$`\\\"' \t\n*?[#~=%") != strlen(argv[0])) { -#ifndef WIN32 +#ifndef GIT_WINDOWS_NATIVE nargv[nargc++] = SHELL_PATH; #else nargv[nargc++] = "sh"; @@ -182,7 +182,7 @@ static const char **prepare_shell_cmd(const char **argv) return nargv; } -#ifndef WIN32 +#ifndef GIT_WINDOWS_NATIVE static int execv_shell_cmd(const char **argv) { const char **nargv = prepare_shell_cmd(argv); @@ -193,7 +193,7 @@ static int execv_shell_cmd(const char **argv) } #endif -#ifndef WIN32 +#ifndef GIT_WINDOWS_NATIVE static int child_err = 2; static int child_notifier = -1; @@ -334,7 +334,7 @@ fail_pipe: trace_argv_printf(cmd->argv, "trace: run_command:"); fflush(NULL); -#ifndef WIN32 +#ifndef GIT_WINDOWS_NATIVE { int notify_pipe[2]; if (pipe(notify_pipe)) diff --git a/test-chmtime.c b/test-chmtime.c index 02b42ba..1cffa12 100644 --- a/test-chmtime.c +++ b/test-chmtime.c @@ -87,7 +87,7 @@ int main(int argc, const char *argv[]) return -1; } -#ifdef WIN32 +#ifdef GIT_WINDOWS_NATIVE if (!(sb.st_mode & S_IWUSR) && chmod(argv[i], sb.st_mode | S_IWUSR)) { fprintf(stderr, "Could not make user-writable %s: %s", diff --git a/thread-utils.c b/thread-utils.c index 7f4b76a..97396a7 100644 --- a/thread-utils.c +++ b/thread-utils.c @@ -24,7 +24,7 @@ int online_cpus(void) long ncpus; #endif -#ifdef _WIN32 +#ifdef GIT_WINDOWS_NATIVE SYSTEM_INFO info; GetSystemInfo(&info); -- 1.8.2 ``` ## Jonathan Nieder, 2013-04-29 05:11 Subject: Re: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS Message-ID: <20130429051059.GC8031@elie.Belkin> URL: https://gitlist.dev/e/20130429051059.GC8031%40elie.Belkin In-Reply-To: <517C29BE.6050002@ramsay1.demon.co.uk> ``` Ramsay Jones wrote: > After this change, it should be possible to drop the > CYGWIN_V15_WIN32API setting without any negative effect. > > [rj: %s/NATIVE_WINDOWS/GIT_NATIVE_WINDOWS/g ] > > Signed-off-by: Jonathan Nieder > Signed-off-by: Ramsay Jones Yay! Thanks for finishing it. For what it's worth, Reviewed-by: Jonathan Nieder ``` ## Junio C Hamano, 2013-04-29 05:46 Subject: Re: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS Message-ID: <7v38u9opnk.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v38u9opnk.fsf%40alter.siamese.dyndns.org In-Reply-To: <20130429051059.GC8031@elie.Belkin> ``` Jonathan Nieder writes: > Ramsay Jones wrote: > >> After this change, it should be possible to drop the >> CYGWIN_V15_WIN32API setting without any negative effect. >> >> [rj: %s/NATIVE_WINDOWS/GIT_NATIVE_WINDOWS/g ] >> >> Signed-off-by: Jonathan Nieder >> Signed-off-by: Ramsay Jones > > Yay! Thanks for finishing it. > > For what it's worth, > Reviewed-by: Jonathan Nieder Wait. The proposed commit log message talks about native-windows but throughout the code it is windows-native [I'll reword when I rebase-i to add your reviewed-by]. While I really like seeing an unfinished topic completed by tying its loose ends like this patch does, it feels a bit too late for the cycle, especially given that we _know_ the changes still need to be tested on a platform that the series is expected to affect. Could somebody who builds regularly on Cygwin 1.7 try to see if these two patches are OK? Reports from people without previous experience with Git on Cygwin who freshly install Cygwin 1.7 only to test these two patches do not count, because they do not know what is expected and cannot tell regressions from know limitations. Thanks. ``` ## Ramsay Jones, 2013-04-29 23:22 Subject: Re: [PATCH 1/2] mingw: rename WIN32 cpp macro to GIT_NATIVE_WINDOWS Message-ID: <517F00D0.5010103@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/517F00D0.5010103%40ramsay1.demon.co.uk In-Reply-To: <7v38u9opnk.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano wrote: > Jonathan Nieder writes: >> Ramsay Jones wrote: [snip] > While I really like seeing an unfinished topic completed by tying > its loose ends like this patch does, it feels a bit too late for the > cycle, especially given that we _know_ the changes still need to be > tested on a platform that the series is expected to affect. Yes, I suspect it is low risk, but there is no need to include it in this cycle. ATB, Ramsay Jones ```