# [PATCH 1/6] clone: Make the 'junk_mode' symbol a file static 3 messages from 2013-04-27 to 2013-04-28. Participants: Ramsay Jones, Jeff King, Eric Sunshine. Thread: https://gitlist.dev/t/33636 ## Ramsay Jones, 2013-04-27 18:39 Subject: [PATCH 1/6] clone: Make the 'junk_mode' symbol a file static Message-ID: <517C1B48.5090206@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/517C1B48.5090206%40ramsay1.demon.co.uk ``` Sparse issues an "'junk_mode' not declared. Should it be static?" warning. In order to suppress the warning, since this symbol does not need more than file visibility, we simply add the static modifier to it's declaration. Signed-off-by: Ramsay Jones --- builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index 58fee98..035ab64 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -387,7 +387,7 @@ static void clone_local(const char *src_repo, const char *dest_repo) static const char *junk_work_tree; static const char *junk_git_dir; static pid_t junk_pid; -enum { +static enum { JUNK_LEAVE_NONE, JUNK_LEAVE_REPO, JUNK_LEAVE_ALL -- 1.8.2 ``` ## Jeff King, 2013-04-27 23:21 Subject: Re: [PATCH 1/6] clone: Make the 'junk_mode' symbol a file static Message-ID: <20130427232124.GA13800@sigill.intra.peff.net> URL: https://gitlist.dev/e/20130427232124.GA13800%40sigill.intra.peff.net In-Reply-To: <517C1B48.5090206@ramsay1.demon.co.uk> ``` On Sat, Apr 27, 2013 at 07:39:04PM +0100, Ramsay Jones wrote: > Sparse issues an "'junk_mode' not declared. Should it be static?" > warning. In order to suppress the warning, since this symbol does > not need more than file visibility, we simply add the static > modifier to it's declaration. > [...] > -enum { > +static enum { > JUNK_LEAVE_NONE, Thanks. This one was done by me, and yes it should be static. I think it is because I originally typed: enum junk_mode { ... }; static enum junk_mode junk_mode; and then later dropped the named type, but forgot to keep the static keyword. -Peff ``` ## Eric Sunshine, 2013-04-28 01:55 Subject: Re: [PATCH 1/6] clone: Make the 'junk_mode' symbol a file static Message-ID: URL: https://gitlist.dev/e/CAPig%2BcSJujQ0qMMJ4%2Bsqob_sTzPEokF81bjm69KFK5Ja%2BmCV8g%40mail.gmail.com In-Reply-To: <517C1B48.5090206@ramsay1.demon.co.uk> ``` On Sat, Apr 27, 2013 at 2:39 PM, Ramsay Jones wrote: > Sparse issues an "'junk_mode' not declared. Should it be static?" > warning. In order to suppress the warning, since this symbol does > not need more than file visibility, we simply add the static > modifier to it's declaration. s/it's/its/ > Signed-off-by: Ramsay Jones ```