threads / patch / 33594

patchcompletion: remove duplicate block for "git commit -c"

Subject: [PATCH] completion: remove duplicate block for "git commit -c"

## tl;dr

2 messages between Apr 24, 2013 and Apr 24, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Mårten Kongstad· Apr 24, 2013, 20:49 UTC · lore
Remove one of two consecutive, identical blocks for "git commit -c".
Signed-off-by: Mårten Kongstad <marten.kongstad@gmail.com>
---
 contrib/completion/git-completion.bash |    7 -------
 1 file changed, 7 deletions(-)
Show changes to contrib/completion/git-completion.bash +0 −7
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 93eba46..f67b0f0 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1182,13 +1182,6 @@ _git_commit ()
 		;;
 	esac
 
-	case "$prev" in
-	-c|-C)
-		__gitcomp_nl "$(__git_refs)" "" "${cur}"
-		return
-		;;
-	esac
-
 	case "$cur" in
 	--cleanup=*)
 		__gitcomp "default strip verbatim whitespace
-- 
1.7.9.5
Junio C Hamano· Apr 24, 2013, 23:04 UTC · re: Mårten Kongstad · lore

Re: [PATCH] completion: remove duplicate block for "git commit -c"

This was caused by a mechanical mismerge at d931e2fb252e (Merge branch 'mp/complete-paths', 2013-02-08), it seems. The side branch fea16b47 wanted to add this block, of course, but the same fix was done independently in 685397585 already.

Thanks for catching it.

← back to recent threads