threads / discuss / 33555

Subtree: My Status

Subject: Subtree: My Status

## tl;dr

6 messages between Apr 20, 2013 and Dec 16, 2013.

replies: 5people: 4as markdown or json

greened@obbligato.org· Apr 20, 2013, 17:59 UTC · lore

Hi folks,

I apologize for being off the grid for a while. We had a baby and unexpectedly ended up in the NICU. We just got him home a week ago. Everyone is doing fine but I had to pretty much drop all non-essential work for a month or so.

Rest assured that I have all of the git-subtree-related mail sitting in my inbox. It will take me some time to process it all -- looks ike there has been a lot of good work!

Please remember that I don't consider myself a gatekeeper to git subtree. In fact I could use some help reviewing and approving patches. If anyone thinks a patch looks good, let Junio know. It's my responsibility to object to things, not your responsibility to wait for me. :) Life happens and I want to make sure git-subtree moves forward.

Thanks everyone for understanding.

                       -David

Jeremy Rosen· Apr 22, 2013, 07:18 UTC · re: greened@obbligato.org · lore

Re: Subtree: My Status

----- Mail original -----

Show 8 quoted lines

> Hi folks,
> 
> I apologize for being off the grid for a while.  We had a baby and
> unexpectedly ended up in the NICU.  We just got him home a week ago.
> Everyone is doing fine but I had to pretty much drop all
> non-essential
> work for a month or so.
>

Good to here that everything is well on your side and congratulation for the baby,

Show 5 quoted lines

> Rest assured that I have all of the git-subtree-related mail sitting
> in
> my inbox.  It will take me some time to process it all -- looks ike
> there has been a lot of good work!
>

no worries, there is no emergency here...

Show 6 quoted lines

> Please remember that I don't consider myself a gatekeeper to git
> subtree.  In fact I could use some help reviewing and approving
> patches.
> If anyone thinks a patch looks good, let Junio know.  It's my
> responsibility to object to things, not your responsibility to wait
> for

I guess it's more or less everybody's responsability to review patches, but it seems to me that for the actual gate-keeping, Junio considers you in charge of git-subtree... Maybe there is an organisational quirk to sort- out here... Junio ?

Adam Spiers· Dec 12, 2013, 18:24 UTC · re: Jeremy Rosen · lore

Re: Subtree: My Status

On Mon, Apr 22, 2013 at 09:18:46AM +0200, Jeremy Rosen wrote:

Show 12 quoted lines

> David Green wrote:
> > Please remember that I don't consider myself a gatekeeper to git
> > subtree.  In fact I could use some help reviewing and approving
> > patches.
> > If anyone thinks a patch looks good, let Junio know.  It's my
> > responsibility to object to things, not your responsibility to wait
> > for
> 
> I guess it's more or less everybody's responsability to review patches, but
> it seems to me that for the actual gate-keeping, Junio considers you 
> in charge of git-subtree... Maybe there is an organisational quirk to sort-
> out here... Junio ?

I can't see any resolution to this in the mail archives. What's the process for getting subtree patches accepted?

Junio C Hamano· Dec 12, 2013, 19:26 UTC · re: Adam Spiers · lore

Re: Subtree: My Status

Adam Spiers <git@adamspiers.org> writes:

Show 16 quoted lines

> On Mon, Apr 22, 2013 at 09:18:46AM +0200, Jeremy Rosen wrote:
>> David Green wrote:
>> > Please remember that I don't consider myself a gatekeeper to git
>> > subtree.  In fact I could use some help reviewing and approving
>> > patches.
>> > If anyone thinks a patch looks good, let Junio know.  It's my
>> > responsibility to object to things, not your responsibility to wait
>> > for
>> 
>> I guess it's more or less everybody's responsability to review patches, but
>> it seems to me that for the actual gate-keeping, Junio considers you 
>> in charge of git-subtree... Maybe there is an organisational quirk to sort-
>> out here... Junio ?
>
> I can't see any resolution to this in the mail archives.  What's the
> process for getting subtree patches accepted?

Somebody take the ownership of the area, if David Green who earlier volunteered to do so and worked on it needs help reviewing, helping polishing and giving thumbs-up on the patches, perhaps?

Adam Spiers· Dec 14, 2013, 15:33 UTC · re: Junio C Hamano · lore

Re: Subtree: My Status

On Thu, Dec 12, 2013 at 11:26:36AM -0800, Junio C Hamano wrote:

Show 20 quoted lines

> Adam Spiers <git@adamspiers.org> writes:
> > On Mon, Apr 22, 2013 at 09:18:46AM +0200, Jeremy Rosen wrote:
> >> David Green wrote:
> >> > Please remember that I don't consider myself a gatekeeper to
> >> > git subtree.  In fact I could use some help reviewing and
> >> > approving patches.  If anyone thinks a patch looks good, let
> >> > Junio know.  It's my responsibility to object to things, not
> >> > your responsibility to wait for
> >> 
> >> I guess it's more or less everybody's responsability to review
> >> patches, but it seems to me that for the actual gate-keeping,
> >> Junio considers you in charge of git-subtree... Maybe there is an
> >> organisational quirk to sort- out here... Junio ?
> >
> > I can't see any resolution to this in the mail archives.  What's the
> > process for getting subtree patches accepted?
> 
> Somebody take the ownership of the area, if David Green who earlier
> volunteered to do so and worked on it needs help reviewing, helping
> polishing and giving thumbs-up on the patches, perhaps?

I *may* be able to help a bit in the coming weeks, given that it's reasonably likely I'll be using git-subtree for professional reasons.

However I'm not clear from the above whether you're suggesting that someone should take over ownership from David, or merely help him?

And in either case, what would be your criteria and process for accepting patches, given that ultimately you're still in control of the repository?

Thanks, Adam

Junio C Hamano· Dec 16, 2013, 19:18 UTC · re: Adam Spiers · lore

Re: Subtree: My Status

Adam Spiers <git@adamspiers.org> writes:

Show 9 quoted lines

>> Somebody take the ownership of the area, if David Green who earlier
>> volunteered to do so and worked on it needs help reviewing, helping
>> polishing and giving thumbs-up on the patches, perhaps?
>
> I *may* be able to help a bit in the coming weeks, given that it's
> reasonably likely I'll be using git-subtree for professional reasons.
>
> However I'm not clear from the above whether you're suggesting that
> someone should take over ownership from David, or merely help him?

I'll leave that between you and David, and possibly other people who are interested in advancing "git subtree" who may volunteer.

> And in either case, what would be your criteria and process for
> accepting patches, given that ultimately you're still in control of
> the repository?

I'd imagine for the first few rounds of patchsets I'll be picky about styles and design, but once whoever eventually becomes the volunteer subarea maintainer (perhaps you) demonsrates that s/he has good enough motivation and taste to keep the codebase clean and user experience consistent, I'd delegate more and more decision what to include and reject to that subarea maintainer, just like any material in the contrib/ area.