# [PATCH] fast-export: fix argument name in error messages 2 messages from 2013-04-12 to 2013-04-12. Participants: Paul Price, Junio C Hamano. Thread: https://gitlist.dev/t/33489 ## Paul Price, 2013-04-12 14:05 Subject: [PATCH] fast-export: fix argument name in error messages Message-ID: <43FA6C2A-A2C3-474F-889A-8059CE24175A@astro.princeton.edu> URL: https://gitlist.dev/e/43FA6C2A-A2C3-474F-889A-8059CE24175A%40astro.princeton.edu ``` The --signed-tags argument is plural, while error messages referred to --signed-tag (singular). Tweak error messages to correspond to the argument. Signed-off-by: Paul Price --- First submission; please report any formatting or style errors privately. builtin/fast-export.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/fast-export.c b/builtin/fast-export.c index 77dffd1..ad9d0c4 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c @@ -43,7 +43,7 @@ static int parse_opt_signed_tag_mode(const struct option *opt, else if (!strcmp(arg, "strip")) signed_tag_mode = STRIP; else - return error("Unknown signed-tag mode: %s", arg); + return error("Unknown signed-tags mode: %s", arg); return 0; } @@ -416,7 +416,7 @@ static void handle_tag(const char *name, struct tag *tag) switch(signed_tag_mode) { case ABORT: die ("Encountered signed tag %s; use " - "--signed-tag= to handle it.", + "--signed-tags= to handle it.", sha1_to_hex(tag->object.sha1)); case WARN: warning ("Exporting signed tag %s", -- 1.8.1.1 ``` ## Junio C Hamano, 2013-04-12 16:50 Subject: Re: [PATCH] fast-export: fix argument name in error messages Message-ID: <7vy5cnelrw.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vy5cnelrw.fsf%40alter.siamese.dyndns.org In-Reply-To: <43FA6C2A-A2C3-474F-889A-8059CE24175A@astro.princeton.edu> ``` Paul Price writes: > The --signed-tags argument is plural, while error messages referred > to --signed-tag (singular). Tweak error messages to correspond to the > argument. > > Signed-off-by: Paul Price > --- > First submission; please report any formatting or style errors privately. The patch is trivially whitespace-damaged but was easy enough to correct locally here. Applied; thanks. > > builtin/fast-export.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/builtin/fast-export.c b/builtin/fast-export.c > index 77dffd1..ad9d0c4 100644 > --- a/builtin/fast-export.c > +++ b/builtin/fast-export.c > @@ -43,7 +43,7 @@ static int parse_opt_signed_tag_mode(const struct option *opt, > else if (!strcmp(arg, "strip")) > signed_tag_mode = STRIP; > else > - return error("Unknown signed-tag mode: %s", arg); > + return error("Unknown signed-tags mode: %s", arg); > return 0; > } > > @@ -416,7 +416,7 @@ static void handle_tag(const char *name, struct tag *tag) > switch(signed_tag_mode) { > case ABORT: > die ("Encountered signed tag %s; use " > - "--signed-tag= to handle it.", > + "--signed-tags= to handle it.", > sha1_to_hex(tag->object.sha1)); > case WARN: > warning ("Exporting signed tag %s", ```