# [PATCH] test-lint-duplicates: consider only numbered test cases

2 messages from 2013-04-10 to 2013-04-10. Participants: Torsten Bögershausen, Jeff King.
Thread: https://gitlist.dev/t/33458

## Torsten Bögershausen, 2013-04-10 14:22

Subject: [PATCH] test-lint-duplicates: consider only numbered test cases
Message-ID: <201304101622.58688.tboegi@web.de>
URL: https://gitlist.dev/e/201304101622.58688.tboegi%40web.de

```
Running make inside contrib/remote-helpers may fail in "test-lint-duplicates"

This was because the regexp checking for duplicate numbers strips everything
after the first "-" in the filename, including the prefix.

As a result, 2 pathnames like
"xxxx/contrib/remote-helpers/test-XX.sh" and
"xxxx/contrib/remote-helpers/test-YY.sh"

are both converted into
"xxxx/contrib/remote", and reported as duplicate.

Improve the regexp:
- strip the leading path and look only at the basename
- only look at files which have tNNNN- (where N stand for a digit) in the name

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---

http://comments.gmane.org/gmane.comp.version-control.git/214194

 t/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/t/Makefile b/t/Makefile
index 1923cc1..cfd6d5a 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -48,7 +48,9 @@ clean: clean-except-prove-cache
 test-lint: test-lint-duplicates test-lint-executable test-lint-shell-syntax
 
 test-lint-duplicates:
-	@dups=`echo $(T) | tr ' ' '\n' | sed 's/-.*//' | sort | uniq -d` && \
+	@dups=`echo $(T) | tr ' ' '\n' | \
+		sed -e 's,.*/,,' -ne 's|\(.*/\)*t\([0-9][0-9][0-9][0-9]\)-.*|\2|p' | \
+		sort | uniq -d` && \
 		test -z "$$dups" || { \
 		echo >&2 "duplicate test numbers:" $$dups; exit 1; }
 
-- 
1.8.2.282.g4bc7171

```

## Jeff King, 2013-04-10 16:03

Subject: Re: [PATCH] test-lint-duplicates: consider only numbered test cases
Message-ID: <20130410160350.GC10749@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20130410160350.GC10749%40sigill.intra.peff.net
In-Reply-To: <201304101622.58688.tboegi@web.de>

```
On Wed, Apr 10, 2013 at 04:22:57PM +0200, Torsten Bögershausen wrote:

> Running make inside contrib/remote-helpers may fail in "test-lint-duplicates"
> 
> This was because the regexp checking for duplicate numbers strips everything
> after the first "-" in the filename, including the prefix.
> 
> As a result, 2 pathnames like
> "xxxx/contrib/remote-helpers/test-XX.sh" and
> "xxxx/contrib/remote-helpers/test-YY.sh"
> 
> are both converted into
> "xxxx/contrib/remote", and reported as duplicate.
> 
> Improve the regexp:
> - strip the leading path and look only at the basename
> - only look at files which have tNNNN- (where N stand for a digit) in the name
> 
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---

Yeah, I think this is fine. Though note that we already have Felipe's
patch to just set TEST_LINT explicitly, so I think it is a non-issue
now.

-Peff

```