# [PATCH] format-patch: trivial cleanup 2 messages from 2013-04-07 to 2013-04-07. Participants: Felipe Contreras, Junio C Hamano. Thread: https://gitlist.dev/t/33412 ## Felipe Contreras, 2013-04-07 07:18 Subject: [PATCH] format-patch: trivial cleanup Message-ID: <1365319139-12362-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1365319139-12362-1-git-send-email-felipe.contreras%40gmail.com ``` Signed-off-by: Felipe Contreras --- Actually, now that we are on it. After applying my latest patch series, this makes sense. builtin/log.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index fab7998..7cf9277 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1058,12 +1058,10 @@ static char *find_branch_name(struct rev_info *rev) else return NULL; } - if (0 <= positive) { - ref = rev->cmdline.rev[positive].name; - tip_sha1 = rev->cmdline.rev[positive].item->sha1; - } else { + if (positive < 0) return NULL; - } + ref = rev->cmdline.rev[positive].name; + tip_sha1 = rev->cmdline.rev[positive].item->sha1; if (dwim_ref(ref, strlen(ref), branch_sha1, &full_ref) && !prefixcmp(full_ref, "refs/heads/") && !hashcmp(tip_sha1, branch_sha1)) -- 1.8.2 ``` ## Junio C Hamano, 2013-04-07 08:16 Subject: Re: [PATCH] format-patch: trivial cleanup Message-ID: <7vzjxa7o3j.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vzjxa7o3j.fsf%40alter.siamese.dyndns.org In-Reply-To: <1365319139-12362-1-git-send-email-felipe.contreras@gmail.com> ``` Felipe Contreras writes: > Signed-off-by: Felipe Contreras > --- > > Actually, now that we are on it. After applying my latest patch series, this makes sense. Yes, this is way easier to read. > > builtin/log.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/builtin/log.c b/builtin/log.c > index fab7998..7cf9277 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -1058,12 +1058,10 @@ static char *find_branch_name(struct rev_info *rev) > else > return NULL; > } > - if (0 <= positive) { > - ref = rev->cmdline.rev[positive].name; > - tip_sha1 = rev->cmdline.rev[positive].item->sha1; > - } else { > + if (positive < 0) > return NULL; > - } > + ref = rev->cmdline.rev[positive].name; > + tip_sha1 = rev->cmdline.rev[positive].item->sha1; > if (dwim_ref(ref, strlen(ref), branch_sha1, &full_ref) && > !prefixcmp(full_ref, "refs/heads/") && > !hashcmp(tip_sha1, branch_sha1)) ```