threads / patch / 33335

patchfixup! pathspec: support :(glob) syntax

Subject: [PATCH] fixup! pathspec: support :(glob) syntax

## tl;dr

3 messages between Mar 30, 2013 and Apr 1, 2013. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

John Keeping· Mar 30, 2013, 17:51 UTC · lore

A formatting fix for a patch currently cooking on nd/magic-pathspecs (cc3d8045ec1e2323c5654e2af834e887f26deb7e).

--- The latest version of this wasn't posted to the list in full, so I'm not sure about the recommended way to provide feedback. Hopefully this is easy to squash in.

 Documentation/git.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to Documentation/git.txt +2 −0
diff --git a/Documentation/git.txt b/Documentation/git.txt
index f423cd6..d6eb0d3 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -443,13 +443,13 @@ help ...`.
 	This is equivalent to setting the `GIT_LITERAL_PATHSPECS` environment
 	variable to `1`.
 
---glob-pathspecs:
+--glob-pathspecs::
 	Add "glob" magic to all pathspec. This is equivalent to setting
 	the `GIT_GLOB_PATHSPECS` environment variable to `1`. Disabling
 	globbing on individual pathspecs can be done using pathspec
 	magic ":(literal)"
 
---noglob-pathspecs:
+--noglob-pathspecs::
 	Add "literal" magic to all pathspec. This is equivalent to setting
 	the `GIT_NOGLOB_PATHSPECS` environment variable to `1`. Enabling
 	globbing on individual pathspecs can be done using pathspec

-- 
1.8.2.515.g52d783d
Junio C Hamano· Apr 1, 2013, 02:51 UTC · re: John Keeping · lore

Re: [PATCH] fixup! pathspec: support :(glob) syntax

John Keeping <john@keeping.me.uk> writes:
Show 7 quoted lines
> A formatting fix for a patch currently cooking on nd/magic-pathspecs
> (cc3d8045ec1e2323c5654e2af834e887f26deb7e).
>
> ---
> The latest version of this wasn't posted to the list in full, so I'm not
> sure about the recommended way to provide feedback.  Hopefully this is
> easy to squash in.

This is one of the reasons why I do not like to directly pull from contributors.

Checking by others from the sidelines what was requested to be pulled like you did is greatly appreciated.

Thanks.
Duy Nguyen· Apr 1, 2013, 03:08 UTC · re: Junio C Hamano · lore

Re: [PATCH] fixup! pathspec: support :(glob) syntax

On Mon, Apr 1, 2013 at 9:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> John Keeping <john@keeping.me.uk> writes:
>
>> A formatting fix for a patch currently cooking on nd/magic-pathspecs
>> (cc3d8045ec1e2323c5654e2af834e887f26deb7e).
>>
>> ---
>> The latest version of this wasn't posted to the list in full, so I'm not
>> sure about the recommended way to provide feedback.  Hopefully this is
>> easy to squash in.
>
> This is one of the reasons why I do not like to directly pull from
> contributors.
>
> Checking by others from the sidelines what was requested to be
> pulled like you did is greatly appreciated.

This bug exists in v1 [1] as well. Do you want me to resend or you will squash it in yourself?

[1] http://article.gmane.org/gmane.comp.version-control.git/218231 -- Duy

← back to recent threads