# [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message 3 messages from 2013-03-21 to 2013-03-21. Participants: Max Nanasy, Junio C Hamano. Thread: https://gitlist.dev/t/33250 ## Max Nanasy, 2013-03-21 19:53 Subject: [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message Message-ID: URL: https://gitlist.dev/e/CAM998vHDay2o55Q3v4tfh%3DtvcmpOHHCPX-Ya5KxVxsn3%3Djzs3A%40mail.gmail.com ``` In the warning message printed when rename or unmodified copy detection was skipped due to too many files, change "diff.renamelimit" to "diff.renameLimit", in order to make it consistent with git documentation, which consistently uses "diff.renameLimit". Signed-off-by: Max Nanasy --- diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diff.c b/diff.c index 156fec4..052974e 100644 --- a/diff.c +++ b/diff.c @@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status) { int result = 0; - diff_warn_rename_limit("diff.renamelimit", + diff_warn_rename_limit("diff.renameLimit", opt->needed_rename_limit, opt->degraded_cc_to_c); if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) && -- 1.8.1.3 ``` ## Junio C Hamano, 2013-03-21 20:43 Subject: Re: [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message Message-ID: <7va9pwa3h9.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7va9pwa3h9.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Max Nanasy writes: > In the warning message printed when rename or unmodified copy > detection was skipped due to too many files, change "diff.renamelimit" > to "diff.renameLimit", in order to make it consistent with git > documentation, which consistently uses "diff.renameLimit". > > Signed-off-by: Max Nanasy > --- I "git grep"ed around and it tells me that this is the only such place. Thanks. The patch is severely whitespace damaged. If you plan to keep contributing to Git, I'd like to make sure that your mail toolchain is sane, so that we do not have to keep hand-adjusting patches submitted by you before applying. > diff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/diff.c b/diff.c > index 156fec4..052974e 100644 > --- a/diff.c > +++ b/diff.c > @@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status) > { > int result = 0; > > - diff_warn_rename_limit("diff.renamelimit", > + diff_warn_rename_limit("diff.renameLimit", > opt->needed_rename_limit, > opt->degraded_cc_to_c); > if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) && > -- > 1.8.1.3 ``` ## Max Nanasy, 2013-03-21 22:14 Subject: [PATCH v2] diff.c: diff.renamelimit => diff.renameLimit in message Message-ID: <1363904078-98433-1-git-send-email-max.nanasy@gmail.com> URL: https://gitlist.dev/e/1363904078-98433-1-git-send-email-max.nanasy%40gmail.com In-Reply-To: <7va9pwa3h9.fsf@alter.siamese.dyndns.org> ``` In the warning message printed when rename or unmodified copy detection was skipped due to too many files, change "diff.renamelimit" to "diff.renameLimit", in order to make it consistent with git documentation, which consistently uses "diff.renameLimit". Signed-off-by: Max Nanasy --- Junio C Hamano pobox.com> writes: > > The patch is severely whitespace damaged. If you plan to keep > contributing to Git, I'd like to make sure that your mail toolchain > is sane, so that we do not have to keep hand-adjusting patches > submitted by you before applying. > I composed the first patch through the GMail web interface, which converted tabs to spaces. I'm retrying this one through git send-email. diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diff.c b/diff.c index 156fec4..052974e 100644 --- a/diff.c +++ b/diff.c @@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status) { int result = 0; - diff_warn_rename_limit("diff.renamelimit", + diff_warn_rename_limit("diff.renameLimit", opt->needed_rename_limit, opt->degraded_cc_to_c); if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) && -- 1.8.1.3 ```