# [PATCH 2/2] send-email: Add --cc 2 messages from 2006-02-13 to 2006-02-13. Participants: Ryan Anderson. Thread: https://gitlist.dev/t/3318 ## Ryan Anderson, 2006-02-13 08:22 Subject: [PATCH 2/2] send-email: Add --cc Message-ID: <1139818924460-git-send-email-ryan@michonline.com> URL: https://gitlist.dev/e/1139818924460-git-send-email-ryan%40michonline.com In-Reply-To: <11398189241095-git-send-email-ryan@michonline.com> ``` Since Junio used this in an example, and I've personally tried to use it, I suppose the option should actually exist. Signed-off-by: Ryan Anderson --- Documentation/git-send-email.txt | 3 +++ git-send-email.perl | 8 ++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) 6d18725b9d46259162cfe54c9e0e369558394816 diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index c2f52f5..8c58685 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -24,6 +24,9 @@ OPTIONS ------- The options available are: +--cc:: + Specify a starting "Cc:" value for each email. + --chain-reply-to, --no-chain-reply-to:: If this is set, each email will be sent as a reply to the previous email sent. If disabled with "--no-chain-reply-to", all emails after diff --git a/git-send-email.perl b/git-send-email.perl index abffca5..13b85dd 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -31,7 +31,7 @@ sub cleanup_compose_files(); my $compose_filename = ".msg.$$"; # Variables we fill in automatically, or via prompting: -my (@to,@cc,$initial_reply_to,$initial_subject,@files,$from,$compose); +my (@to,@cc,@initial_cc,$initial_reply_to,$initial_subject,@files,$from,$compose); # Behavior modification variables my ($chain_reply_to, $smtp_server, $quiet, $suppress_from, $no_signed_off_cc) = (1, "localhost", 0, 0, 0); @@ -48,6 +48,7 @@ my $rc = GetOptions("from=s" => \$from, "in-reply-to=s" => \$initial_reply_to, "subject=s" => \$initial_subject, "to=s" => \@to, + "cc=s" => \@initial_cc, "chain-reply-to!" => \$chain_reply_to, "smtp-server=s" => \$smtp_server, "compose" => \$compose, @@ -199,6 +200,9 @@ Options: --to Specify the primary "To:" line of the email. + --cc Specify an initial "Cc:" list for the entire series + of emails. + --compose Use \$EDITOR to edit an introductory message for the patch series. @@ -298,7 +302,7 @@ $subject = $initial_subject; foreach my $t (@files) { open(F,"<",$t) or die "can't open file $t"; - @cc = (); + @cc = @initial_cc; my $found_mbox = 0; my $header_done = 0; $message = ""; -- 1.2.0.g6d18 ``` ## Ryan Anderson, 2006-02-13 08:22 Subject: [PATCH 1/2] send-email: Add some options for controlling how addresses are automatically Message-ID: <11398189241095-git-send-email-ryan@michonline.com> URL: https://gitlist.dev/e/11398189241095-git-send-email-ryan%40michonline.com In-Reply-To: <11398189232404-git-send-email-ryan@michonline.com> ``` Signed-off-by: Ryan Anderson --- Documentation/git-send-email.txt | 7 +++++++ git-send-email.perl | 15 ++++++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) dc4ad3ef1b29ce35dc0ace4d284cfab5e594bfb7 diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 00537d8..c2f52f5 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -48,6 +48,9 @@ The options available are: Only necessary if --compose is also set. If --compose is not set, this will be prompted for. +--no-signed-off-by-cc:: + Do not add emails foudn in Signed-off-by: lines to the cc list. + --quiet:: Make git-send-email less verbose. One line per email should be all that is output. @@ -61,6 +64,10 @@ The options available are: Only necessary if --compose is also set. If --compose is not set, this will be prompted for. +--suppress-from:: + Do not add the From: address to the cc: list, if it shows up in a From: + line. + --to:: Specify the primary recipient of the emails generated. Generally, this will be the upstream maintainer of the diff --git a/git-send-email.perl b/git-send-email.perl index 3f1b3ca..abffca5 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -34,7 +34,7 @@ my $compose_filename = ".msg.$$"; my (@to,@cc,$initial_reply_to,$initial_subject,@files,$from,$compose); # Behavior modification variables -my ($chain_reply_to, $smtp_server, $quiet) = (1, "localhost", 0); +my ($chain_reply_to, $smtp_server, $quiet, $suppress_from, $no_signed_off_cc) = (1, "localhost", 0, 0, 0); # Example reply to: #$initial_reply_to = ''; #<20050203173208.GA23964@foobar.com>'; @@ -52,6 +52,8 @@ my $rc = GetOptions("from=s" => \$from, "smtp-server=s" => \$smtp_server, "compose" => \$compose, "quiet" => \$quiet, + "suppress-from" => \$suppress_from, + "no-signed-off-cc" => \$no_signed_off_cc, ); # Now, let's fill any that aren't set in with defaults: @@ -212,13 +214,19 @@ Options: email sent, rather than to the first email sent. Defaults to on. + --no-signed-off-cc Suppress the automatic addition of email addresses + that appear in a Signed-off-by: line, to the cc: list. + Note: Using this option is not recommended. + --smtp-server If set, specifies the outgoing SMTP server to use. Defaults to localhost. + --suppress-from Supress sending emails to yourself if your address + appears in a From: line. + --quiet Make git-send-email less verbose. One line per email should be all that is output. - Error: Please specify a file or a directory on the command line. EOT exit(1); @@ -304,6 +312,7 @@ foreach my $t (@files) { $subject = $1; } elsif (/^(Cc|From):\s+(.*)$/) { + next if ($2 eq $from && $suppress_from); printf("(mbox) Adding cc: %s from line '%s'\n", $2, $_) unless $quiet; push @cc, $2; @@ -332,7 +341,7 @@ foreach my $t (@files) { } } else { $message .= $_; - if (/^Signed-off-by: (.*)$/i) { + if (/^Signed-off-by: (.*)$/i && !$no_signed_off_cc) { my $c = $1; chomp $c; push @cc, $c; -- 1.2.0.g6d18 ```